From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4DCE4C9E for ; Mon, 11 Jul 2022 21:35:47 +0000 (UTC) Received: by mail-oo1-f47.google.com with SMTP id r8-20020a4abf08000000b00425b1256454so1185703oop.13 for ; Mon, 11 Jul 2022 14:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3jZ6/mXUs3oGj5vCmYXuF6klL3B3NB7ms0SX6lE5t8E=; b=iz9U5u5B1yJwA1KvdhbtiZzYX+Sk497a6ZP9IiekQQUJmU2D20eBWtbMFQ8QbQegLK cCr4mCkMExokKf8YQyjUshLSZkd1iu11tW73cDLrfFHX9T/o9aff6j4j75LbLTqKAdLM PEse1RmFxhrzh1O6ke19Jm7IG21uIfThHWpWsSv5DcTb5vYAsv9lmocL5rAfEhSZV3JL GVTz/KTyAoSBX9az8VDVj7Zyr7X78LN4kuHCtW3gmfVFlN+rQDkUPLxptrpq1mrQc4mq otUi23Zv5uabN3MAOPSrJsUjud3n77+hX9LOhyYLG2S+Xu6dDR1RJhVAhFDlWP4sPZdE KJmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3jZ6/mXUs3oGj5vCmYXuF6klL3B3NB7ms0SX6lE5t8E=; b=r5SEt/yR2fmFzMCHB+ZGbyAR2Gw3Mjfs9rWt5tHH6iCFtvGuZkILCn2+jSJTEMw+di b4wkdUWpyYQOmFl9kC7dRXL7BGJUW2i30eTqVRduFqxJndsNsapD//J1NE4G8hBsVd5D Pyie0Il8BosaoFvAmahZJXiQU7IJEQCQaIw3K/KNwyNi+XPgkceB3UJVx7NBzPQ5WPdt vnM6v35LQMW1yUJE1/V+AAWNJalrtEUn/vpCppf5spHz8pa8sZFClKe+iKF942FJXfX2 PFjhV1re+6I/7oLw/l9PVdCCG1mICuk3ZiQmxbIoYNDmCDikOXNE5eOH1Dhb83FwppAz H+9Q== X-Gm-Message-State: AJIora8ybrrzUNpCLoeAhguC/IYKlLuivgP21rqCf1XfszhJ+RSjJ7Xp VPZXYKwU5/8yKzxSl9kyavtyhg== X-Google-Smtp-Source: AGRyM1tAnze5Z/cPxlu8wR0AxcpNqBITgN2Oh8PaM8XO15TGC5Hl82yTXDAM9iJo+ihwZ25tK/pYOQ== X-Received: by 2002:a4a:b306:0:b0:425:8afc:a3d8 with SMTP id m6-20020a4ab306000000b004258afca3d8mr7403721ooo.47.1657575346922; Mon, 11 Jul 2022 14:35:46 -0700 (PDT) Received: from eze-laptop ([190.190.187.68]) by smtp.gmail.com with ESMTPSA id o9-20020a056870524900b00101c9597c6fsm3724251oai.28.2022.07.11.14.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 14:35:46 -0700 (PDT) Date: Mon, 11 Jul 2022 18:35:40 -0300 From: Ezequiel Garcia To: Jernej Skrabec Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, mchehab@kernel.org, gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] media: cedrus: Add helper for determining number of elements Message-ID: References: <20220620175517.648767-1-jernej.skrabec@gmail.com> <20220620175517.648767-7-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220620175517.648767-7-jernej.skrabec@gmail.com> On Mon, Jun 20, 2022 at 07:55:16PM +0200, Jernej Skrabec wrote: > Now that controls can be dynamic arrays, we need to know how many > elements are in such array. Add a helper for that. > > Signed-off-by: Jernej Skrabec Reviewed-by: Ezequiel Garcia > --- > drivers/staging/media/sunxi/cedrus/cedrus.c | 11 +++++++++++ > drivers/staging/media/sunxi/cedrus/cedrus.h | 1 + > 2 files changed, 12 insertions(+) > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c > index 99c87319d2b4..b855e608885c 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -232,6 +232,17 @@ void *cedrus_find_control_data(struct cedrus_ctx *ctx, u32 id) > return NULL; > } > > +u32 cedrus_get_num_of_controls(struct cedrus_ctx *ctx, u32 id) > +{ > + unsigned int i; > + > + for (i = 0; ctx->ctrls[i]; i++) > + if (ctx->ctrls[i]->id == id) > + return ctx->ctrls[i]->elems; > + > + return 0; > +} > + > static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx) > { > struct v4l2_ctrl_handler *hdl = &ctx->hdl; > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.h b/drivers/staging/media/sunxi/cedrus/cedrus.h > index d2b697a9ded2..15a1bdbf6a1f 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus.h > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.h > @@ -261,5 +261,6 @@ vb2_to_cedrus_buffer(const struct vb2_buffer *p) > } > > void *cedrus_find_control_data(struct cedrus_ctx *ctx, u32 id); > +u32 cedrus_get_num_of_controls(struct cedrus_ctx *ctx, u32 id); > > #endif > -- > 2.36.1 >