From: Phillip Potter <phil@philpotter.co.uk>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
dan.carpenter@oracle.com, martin@kaiser.cx,
straube.linux@gmail.com, fmdefrancesco@gmail.com,
abdun.nihaal@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics
Date: Tue, 2 Aug 2022 23:15:16 +0100 [thread overview]
Message-ID: <Yumh9NLeDAMJBJ48@equinox> (raw)
In-Reply-To: <2e838551-e6a3-df5d-a889-baf60c7f99fd@gmail.com>
On Tue, Aug 02, 2022 at 11:10:21PM +0300, Pavel Skripkin wrote:
> Hi Phillip,
>
> Phillip Potter <phil@philpotter.co.uk> says:
> > - if (!rtw_set_802_11_add_wep(padapter, &wep)) {
> > + if (rtw_set_802_11_add_wep(padapter, &wep)) {
> > if (rf_on == pwrpriv->rf_pwrstate)
> > ret = -EOPNOTSUPP;
> > goto exit;
>
> is it intentional to ignore an error in case of rf_on !=
> pwrpriv->rf_pwrstate?
>
>
Hi Pavel,
Somewhat yes, in the sense that this is existing behaviour and changing
it is a semantic change in the driver, thus arguably outside the scope
of a patch/patch set that is intended to just focus on error code
handling (moving from _SUCCESS/_FAIL to 0 and -EWHATEVER).
Not fixed to that by any means though, if you would prefer it be
restructured as well. I need to do a V2 for this anyway.
Regards,
Phil
next prev parent reply other threads:[~2022-08-02 22:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 23:11 [PATCH 0/2] staging: r8188eu: more error code cleanups Phillip Potter
2022-07-28 23:11 ` [PATCH 1/2] staging: r8188eu: remove initializer from ret in rtw_pwr_wakeup Phillip Potter
2022-07-28 23:11 ` [PATCH 2/2] staging: r8188eu: convert rtw_set_802_11_add_wep error code semantics Phillip Potter
2022-07-29 6:48 ` Dan Carpenter
2022-07-30 18:36 ` Phillip Potter
2022-07-31 17:12 ` Joe Perches
2022-08-01 9:17 ` Dan Carpenter
2022-08-02 23:26 ` Phillip Potter
2022-08-01 7:00 ` Dan Carpenter
2022-08-02 20:10 ` Pavel Skripkin
2022-08-02 22:15 ` Phillip Potter [this message]
2022-07-29 6:09 ` [PATCH 0/2] staging: r8188eu: more error code cleanups Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yumh9NLeDAMJBJ48@equinox \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=abdun.nihaal@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox