From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2B37F for ; Wed, 3 Aug 2022 06:08:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7247C433C1; Wed, 3 Aug 2022 06:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659506914; bh=kfuk+0aXynx06c3o3pjaVWnK/rbUgbtj8vWQB25K0h4=; h=Date:From:To:Subject:References:In-Reply-To:From; b=msIDcyFyyQTgdnwORVlVDKoZzClCZT4T7BgWa4BJukdoknUguA/1elFnmNMVKmb9u Bwd73X2uFBEvzefFQUlhf4cec64iCh2hIer2UqlUnBhAhwwovGYhi6ZU3n7CbHmugo t9XKL1KwaiPKRgXO2RgioVF2pGCbSAh/NcMwQOXM= Date: Wed, 3 Aug 2022 08:08:31 +0200 From: Greg KH To: Grzegorz Szymaszek , Larry Finger , Phillip Potter , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: r8188eu: add firmware dependency Message-ID: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Aug 02, 2022 at 07:18:44PM +0200, Grzegorz Szymaszek wrote: > The old rtl8188eu module, removed in commit 55dfa29b43d2 ("staging: > rtl8188eu: remove rtl8188eu driver from staging dir") (Linux kernel > v5.15-rc1), required (through a MODULE_FIRMWARE call()) the > rtlwifi/rtl8188eufw.bin firmware file, which the new r8188eu driver no > longer requires. > > I have tested a few RTL8188EUS-based Wi-Fi cards and, while supported by > both drivers, they do not work when using the new one and the firmware > wasn't manually loaded. According to Larry Finger, the module > maintainer, all such cards need the firmware and the driver should > depend on it (see the linked mails). > > Add a proper MODULE_FIRMWARE() call, like it was done in the old driver. > > Thanks to Greg Kroah-Hartman and Larry Finger for quick responses to my > questions. > > Link: https://answers.launchpad.net/ubuntu/+source/linux-meta-hwe-5.15/+question/702611 > Link: https://lore.kernel.org/lkml/YukkBu3TNODO3or9@nx64de-df6d00/ > Signed-off-by: Grzegorz Szymaszek > --- > drivers/staging/r8188eu/os_dep/os_intfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c > index 891c85b088ca..5bd3022e4b40 100644 > --- a/drivers/staging/r8188eu/os_dep/os_intfs.c > +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c > @@ -18,6 +18,7 @@ MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Realtek Wireless Lan Driver"); > MODULE_AUTHOR("Realtek Semiconductor Corp."); > MODULE_VERSION(DRIVERVERSION); > +MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin"); This looks good, and I'll apply it after 5.20-rc1 is out, but you might want to send a follow-on patch that removes the hard-coded string in 2 places in the driver, and just puts it into a single define somewhere, to make it a bit easier over time. Most other drivers do this as well, so there are examples to look at. thanks, greg k-h