Re: [PATCH] staging: r8188eu: convert rtw_p2p_enable to correct error code semantics

[Phillip Potter <phil@philpotter.co.uk>]

On Wed, Aug 03, 2022 at 03:11:08PM +0300, Dan Carpenter wrote:
> On Wed, Aug 03, 2022 at 12:44:08AM +0100, Phillip Potter wrote:
> > Convert the rtw_p2p_enable function to use correct error code semantics
> > rather than _SUCCESS/_FAIL, and also make sure we allow these to be
> > passed through properly in the one caller where we actually check the
> > code, rtw_wext_p2p_enable.
> > 
> > This change moves these functions to a clearer 'return 0;' style at the
> > end of the function, and in the case of errors now returns ret instead
> > of jumping to the end of the function, so that these can still be passed
> > through but without using a goto to jump to a single return statement at
> > the end which is less clear.
> > 
> > This change moves the driver slowly closer to using standard error code
> > semantics everywhere.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> Looks good.  Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> regards,
> dan carpenter
> 

Thanks for the review Dan, much appreciated.

Regards,
Phil