From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Simone Serra <serrazimone@gmail.com>
Cc: gregkh@linuxfoundation.org, soumya.negi97@gmail.com,
hdegoede@redhat.com, straube.linux@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes compilation errors after checkpatch warnings
Date: Wed, 17 Aug 2022 09:45:07 +0200 [thread overview]
Message-ID: <YvycgyjCwKlsp318@agape.jhs> (raw)
In-Reply-To: <20220809143743.742636-1-serrazimone@gmail.com>
Hello Simone,
On Tue, Aug 09, 2022 at 04:37:43PM +0200, Simone Serra wrote:
> This patch fixes compilation errors produced by the previous commit that resolved a number of checkpatch warnings and errors
>
thanks for your patches. Try to focus on a single checkpatch error
and send a patchset for that one. This makes review easier.
It is a good thing for a patch to fix one thing and to have a proper
commit message describing what the patch is meant to fix. Don't be too
generic.
Always compile test your patches, before submitting!
Thank you,
fabio
prev parent reply other threads:[~2022-08-17 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 14:37 [PATCH] Fixes compilation errors after checkpatch warnings Simone Serra
2022-08-09 15:58 ` Greg KH
2022-08-09 16:22 ` Hans de Goede
2022-08-10 23:35 ` kernel test robot
2022-08-17 7:45 ` Fabio Aiuto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvycgyjCwKlsp318@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=serrazimone@gmail.com \
--cc=soumya.negi97@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox