From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Yury Luneff <yury.lunev@gmail.com>,
Nable <nable.maininbox@googlemail.com>,
andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 01/17] media: atomisp: Use a normal mutex for the main lock
Date: Mon, 12 Sep 2022 14:11:58 +0300 [thread overview]
Message-ID: <Yx8T/uEKvVDoCvsT@smile.fi.intel.com> (raw)
In-Reply-To: <20220911171653.568932-2-hdegoede@redhat.com>
On Sun, Sep 11, 2022 at 07:16:37PM +0200, Hans de Goede wrote:
> There is no reason for atomisp to use a rt_mutex instead of a normal
> mutex, so switch over to a normal mutex.
>
> All the changes in this patch are just s/rt_mutex/mutex/.
>
> This is a preparation patch for switching the ioctl locking over
> to using the video_dev.lock member so that the v4l2-core takes
> care of the locking.
So the idea behind rt_mutex here is to inherit the priority on the task.
I'm wondering what could be possible the bottle neck this is trying to
solve. If there is no other V4L2 driver that does the same, any specific
run flow of AtomISP v2 code that may suffer of this?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-12 11:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 17:16 [PATCH 00/17] media: atomisp: further cleanups / unwanted code removal Hans de Goede
2022-09-11 17:16 ` [PATCH 01/17] media: atomisp: Use a normal mutex for the main lock Hans de Goede
2022-09-12 11:11 ` Andy Shevchenko [this message]
2022-09-21 8:52 ` Hans de Goede
2022-09-21 11:52 ` Andy Shevchenko
2022-09-11 17:16 ` [PATCH 02/17] media: atomisp: Remove unused lock member from struct atomisp_sub_device Hans de Goede
2022-09-11 17:16 ` [PATCH 03/17] media: atomisp: Fix locking around asd->streaming read/write Hans de Goede
2022-09-12 11:26 ` Andy Shevchenko
2022-09-21 8:57 ` Hans de Goede
2022-09-11 17:16 ` [PATCH 04/17] media: atomisp: Remove asd == NULL checks from ioctl handling Hans de Goede
2022-09-11 17:16 ` [PATCH 05/17] media: atomisp: Add atomisp_pipe_check() helper Hans de Goede
2022-09-12 11:30 ` Andy Shevchenko
2022-09-21 9:05 ` Hans de Goede
2022-09-21 11:55 ` Andy Shevchenko
2022-09-11 17:16 ` [PATCH 06/17] media: atomisp: Remove watchdog timer Hans de Goede
2022-09-11 17:16 ` [PATCH 07/17] media: atomisp: Move atomisp_streaming_count() check into __atomisp_css_recover() Hans de Goede
2022-09-11 17:16 ` [PATCH 08/17] media: atomisp: Rework asd->streaming state update in __atomisp_streamoff() Hans de Goede
2022-09-11 17:16 ` [PATCH 09/17] media: atomisp: Drop streamoff_mutex Hans de Goede
2022-09-11 17:16 ` [PATCH 10/17] media: atomisp: Use video_dev.lock for ioctl locking Hans de Goede
2022-09-11 17:16 ` [PATCH 11/17] media: atomisp: Remove a couple of not useful function wrappers Hans de Goede
2022-09-11 17:16 ` [PATCH 12/17] media: atomisp: Drop unnecessary first_streamoff check Hans de Goede
2022-09-11 17:16 ` [PATCH 13/17] media: atomisp: Make atomisp_set_raw_buffer_bitmap() static Hans de Goede
2022-09-11 17:16 ` [PATCH 14/17] media: atomisp: Remove unused atomisp_css_get_dis_statistics() Hans de Goede
2022-09-11 17:16 ` [PATCH 15/17] media: atomisp: Remove const/fixed camera_caps Hans de Goede
2022-09-11 17:16 ` [PATCH 16/17] media: atomisp: Remove atomisp_source_pad_to_stream_id() Hans de Goede
2022-09-12 11:43 ` Andy Shevchenko
2022-09-21 9:11 ` Hans de Goede
2022-09-11 17:16 ` [PATCH 17/17] media: atomisp_gmin_platform: Unexport and split camera_sensor_csi() Hans de Goede
2022-09-12 11:44 ` [PATCH 00/17] media: atomisp: further cleanups / unwanted code removal Andy Shevchenko
2022-09-21 9:20 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx8T/uEKvVDoCvsT@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andrey.i.trufanov@gmail.com \
--cc=andy@kernel.org \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kitakar@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nable.maininbox@googlemail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=yury.lunev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox