From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: cgel.zte@gmail.com, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, paskripkin@gmail.com,
straube.linux@gmail.com, martin@kaiser.cx,
lu.fengchang@zte.com.cn, makvihas@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Zeal-Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.
Date: Fri, 2 Sep 2022 11:05:34 +0200 [thread overview]
Message-ID: <YxHHXgdSLRSKtCyR@kroah.com> (raw)
In-Reply-To: <20220902085446.GN2071@kadam>
On Fri, Sep 02, 2022 at 11:54:46AM +0300, Dan Carpenter wrote:
> On Fri, Sep 02, 2022 at 03:26:28AM +0000, cgel.zte@gmail.com wrote:
> > From: lufengchang <lu.fengchang@zte.com.cn>
> >
> > Reported-by: Zeal-Robot <zealci@zte.com.cn>
> > Signed-off-by: lufengchang <lu.fengchang@zte.com.cn>
> > ---
>
> There is a lot wrong with the format of this patch.
> 1) The subsystem prefix
> 2) The blank line after the subject
> 3) Line wrapping at 75 chars
> 4) Your name is not capitalized
> 5) Greg doesn't like Zeal-Robot tags.
I don't mind the tags, what I mind is that the users of this tool are
not following what is documented in
Documentation/process/researcher-guidelines.rst when using it.
thanks,
greg k-h
prev parent reply other threads:[~2022-09-02 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 3:26 [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable cgel.zte
2022-09-02 5:33 ` Greg KH
2022-09-02 8:54 ` Dan Carpenter
2022-09-02 9:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxHHXgdSLRSKtCyR@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=cgel.zte@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.fengchang@zte.com.cn \
--cc=makvihas@gmail.com \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox