From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A18110D
	for <linux-staging@lists.linux.dev>; Fri,  2 Sep 2022 09:05:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 832E0C433C1;
	Fri,  2 Sep 2022 09:05:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1662109537;
	bh=vxRLf6HfrjpAiqrqIrgsiApd7SWvqgd8XNi/3rbw2CU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Ib24uYNzY3DTEMzcQFgQn62rCuVAmOMQNJHpDj4Jvt/DC+XuRkCaJg09X+PxFkFx1
	 Iizzso5lCU9121xRD6ixloQorWfFCTynt1jjHbXJsrt8Ls9o0FeWA4RqKH7Xl+p/WL
	 4xpbBIUCKwbSJy+v4LsW0z5gwoj+ZKDZ0l848Oik=
Date: Fri, 2 Sep 2022 11:05:34 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: cgel.zte@gmail.com, Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	paskripkin@gmail.com, straube.linux@gmail.com, martin@kaiser.cx,
	lu.fengchang@zte.com.cn, makvihas@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Zeal-Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result
 variable Return 0 instead of storing it in another redundant variable.
Message-ID: <YxHHXgdSLRSKtCyR@kroah.com>
References: <20220902032628.316333-1-lu.fengchang@zte.com.cn>
 <20220902085446.GN2071@kadam>
Precedence: bulk
X-Mailing-List: linux-staging@lists.linux.dev
List-Id: <linux-staging.lists.linux.dev>
List-Subscribe: <mailto:linux-staging+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:linux-staging+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220902085446.GN2071@kadam>

On Fri, Sep 02, 2022 at 11:54:46AM +0300, Dan Carpenter wrote:
> On Fri, Sep 02, 2022 at 03:26:28AM +0000, cgel.zte@gmail.com wrote:
> > From: lufengchang <lu.fengchang@zte.com.cn>
> > 
> > Reported-by: Zeal-Robot <zealci@zte.com.cn>
> > Signed-off-by: lufengchang <lu.fengchang@zte.com.cn>
> > ---
> 
> There is a lot wrong with the format of this patch.
> 1) The subsystem prefix
> 2) The blank line after the subject
> 3) Line wrapping at 75 chars
> 4) Your name is not capitalized
> 5) Greg doesn't like Zeal-Robot tags.

I don't mind the tags, what I mind is that the users of this tool are
not following what is documented in
Documentation/process/researcher-guidelines.rst when using it.

thanks,

greg k-h