From: Greg KH <gregkh@linuxfoundation.org>
To: "Czerwacki, Eial" <eial.czerwacki@sap.com>
Cc: "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"Hammer, Gal" <gal.hammer@sap.com>,
SAP vSMP Linux Maintainer <linux.vsmp@sap.com>
Subject: Re: invalid drv data in show attribute
Date: Tue, 6 Sep 2022 14:09:36 +0200 [thread overview]
Message-ID: <Yxc4gLCBtvM9fQ2M@kroah.com> (raw)
In-Reply-To: <PAXPR02MB731082B5F72C5E2D9D35A4D6817E9@PAXPR02MB7310.eurprd02.prod.outlook.com>
On Tue, Sep 06, 2022 at 07:30:20AM +0000, Czerwacki, Eial wrote:
> >> >> so I can create entries in /sys/hypervisor/vsmp for the global info
> >> >
> >> >Yes.
> >> >
> >> >> and link /sys/bus/vsmp/device/ to /sys/hypervisor/vsmp/boards?
> >> >
> >> >No symlink needed at all, they are independent things, right? What
> >> >would require such a symlink?
> >> >
> >> >thanks,
> >> >
> >> >greg k-h
> >> I'd rather have all the info under one place than in multiple places if possible.
> >> is seams more logical to me
> >
> >That's not how sysfs works, sorry. :)
> >
> >Hypervisors are not normal, the fact that you are using that location in
> >the first place is very very odd, only 1 other in-kernel user is using
> >that. So maybe you don't even need that at all?
> >
> >thanks,
> >
> >greg k-h
> as vSMP is an hypervisor, I've thought /sys/hypervisor is an appropriate location.
For generic stuff related to your hypervisor, yes. But for devices that
are part of your hypervisor bus, no, they do not belong there.
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-06 12:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 14:37 invalid drv data in show attribute Czerwacki, Eial
2022-09-05 5:49 ` Greg KH
2022-09-05 6:07 ` Czerwacki, Eial
2022-09-05 7:01 ` Greg KH
2022-09-05 7:28 ` Czerwacki, Eial
2022-09-05 11:41 ` Greg KH
2022-09-05 12:02 ` Czerwacki, Eial
2022-09-05 12:10 ` Greg KH
2022-09-05 12:56 ` Czerwacki, Eial
2022-09-05 15:12 ` Greg KH
2022-09-05 15:52 ` Czerwacki, Eial
2022-09-05 16:02 ` Greg KH
2022-09-06 7:30 ` Czerwacki, Eial
2022-09-06 12:09 ` Greg KH [this message]
2022-09-06 12:28 ` Czerwacki, Eial
2022-09-05 7:07 ` Greg KH
2022-09-05 7:44 ` Czerwacki, Eial
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxc4gLCBtvM9fQ2M@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=eial.czerwacki@sap.com \
--cc=gal.hammer@sap.com \
--cc=linux-staging@lists.linux.dev \
--cc=linux.vsmp@sap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox