From: Greg KH <gregkh@linuxfoundation.org>
To: xkernel.wang@foxmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: fix potential memory leak in rtw_init_drv_sw()
Date: Fri, 9 Sep 2022 09:48:10 +0200 [thread overview]
Message-ID: <YxrvuoVF+IGfUikb@kroah.com> (raw)
In-Reply-To: <tencent_61623C1C5469E9DF0E448B5936B78E239C05@qq.com>
On Thu, Sep 08, 2022 at 03:31:25PM +0800, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> In rtw_init_drv_sw(), there are various init functions are called to
> populate the padapter structure and some checks for their return value.
> However, except for the first one error path, the other five error paths
> do not properly release the previous allocated resources, which leads to
You have trailing whitespace on your text :(
> various memory leaks.
>
> This patch fixes them and keeps the success and error separate. As there
> is no FooBar device to test with, no runtime testing was performed.
What do you mean by "FooBar"? Please fix that up.
thanks,
greg k-h
prev parent reply other threads:[~2022-09-09 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 7:31 [PATCH v3] staging: rtl8723bs: fix potential memory leak in rtw_init_drv_sw() xkernel.wang
2022-09-09 7:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxrvuoVF+IGfUikb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox