From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] staging: rtl8192e: Fix return type for implementation of ndo_start_xmit
Date: Fri, 9 Sep 2022 09:56:59 +0200 [thread overview]
Message-ID: <YxrxywN9wDypohyY@kroah.com> (raw)
In-Reply-To: <20220908203243.GA23048@matrix-ESPRIMO-P710>
On Thu, Sep 08, 2022 at 10:32:43PM +0200, Philipp Hortmann wrote:
> CFI (Control Flow Integrity) is a safety feature allowing the system to
> detect and react should a potential control flow hijacking occurs. In
> particular, the Forward-Edge CFI protects indirect function calls by
> ensuring the prototype of function that is actually called matches the
> definition of the function hook.
>
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this would get
> cought out by CFI and cause a panic.
>
> Use enums from netdev_tx_t as return value instead, then change return
> type to netdev_tx_t.
>
> Suggested-by: Dan Carpenter <error27@gmail.com>
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
> ---
> Tested with rtl8192e
> Transferred this patch over wlan connection of rtl8192e
> ---
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
Someone sent the same patch before you did:
https://lore.kernel.org/r/20220905130053.10731-1-guozihua@huawei.com
next prev parent reply other threads:[~2022-09-09 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 20:32 [PATCH] staging: rtl8192e: Fix return type for implementation of ndo_start_xmit Philipp Hortmann
2022-09-09 7:56 ` Greg Kroah-Hartman [this message]
2022-09-09 7:58 ` Greg Kroah-Hartman
2022-09-09 8:00 ` Greg Kroah-Hartman
2022-09-09 17:20 ` Philipp Hortmann
2022-09-09 18:01 ` Greg Kroah-Hartman
2022-09-09 18:24 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxrxywN9wDypohyY@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox