From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FDB965A for ; Fri, 9 Sep 2022 07:57:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C2F3C433D6; Fri, 9 Sep 2022 07:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662710221; bh=U36Gv+5fN6mJFH9bSRp7E7L1Sz448wCtSEoqFGd9gWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D6prIJOgtVAUR7yUa3pL+IS3mdQZz6nbueUaHDgRCkQ3Q0H5Y19SIuia0Xvel9W1f s+JYMAS1r8oGrKI4Ga4KIidvWYu8s1JXUViqr+qSxq2EX9LCPvhZ5MFOjPiXc8k8Ds eiG7J0/jt//RWbhhnqtcoYv2eSn7DYjjnI4NG/YU= Date: Fri, 9 Sep 2022 09:56:59 +0200 From: Greg Kroah-Hartman To: Philipp Hortmann Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] staging: rtl8192e: Fix return type for implementation of ndo_start_xmit Message-ID: References: <20220908203243.GA23048@matrix-ESPRIMO-P710> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220908203243.GA23048@matrix-ESPRIMO-P710> On Thu, Sep 08, 2022 at 10:32:43PM +0200, Philipp Hortmann wrote: > CFI (Control Flow Integrity) is a safety feature allowing the system to > detect and react should a potential control flow hijacking occurs. In > particular, the Forward-Edge CFI protects indirect function calls by > ensuring the prototype of function that is actually called matches the > definition of the function hook. > > Since Linux now supports CFI, it will be a good idea to fix mismatched > return type for implementation of hooks. Otherwise this would get > cought out by CFI and cause a panic. > > Use enums from netdev_tx_t as return value instead, then change return > type to netdev_tx_t. > > Suggested-by: Dan Carpenter > Signed-off-by: Philipp Hortmann > --- > Tested with rtl8192e > Transferred this patch over wlan connection of rtl8192e > --- > drivers/staging/rtl8192e/rtllib.h | 2 +- > drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) Someone sent the same patch before you did: https://lore.kernel.org/r/20220905130053.10731-1-guozihua@huawei.com