public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Burak Ozdemir <bozdemir@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: Fix string form declaration
Date: Sat, 10 Sep 2022 07:36:52 +0200	[thread overview]
Message-ID: <YxwidHdwPz2yUAP4@kroah.com> (raw)
In-Reply-To: <CACAQkfXH4smoY2v28DOZ_0uf_2=e8iEDSFbEbTMhU0JPuteOPw@mail.gmail.com>

On Fri, Sep 09, 2022 at 10:50:57PM +0000, Burak Ozdemir wrote:
> I have been  analyzing todo tasks from `Kernel Janitors Projects` and saw
> the following task
> 
> From: Jeff Garzik
> 
> 1) The string form
>         [const] char *foo = "blah";
> creates two variables in the final assembly output, a static string, and a
> char pointer to the static string. The alternate string form
>         [const] char foo[] = "blah";
> is better because it declares a single variable.
> 
> That's why I changed that char * to static const[].

I'm sorry, but I have no context here at all for what this is in
response to.

Remember, some of us get hundreds of changes each day to review, and we
have the short-term memory of a squirrel.  Always include proper context
in an email message so that we know what is going on.

thanks,

greg k-h

      parent reply	other threads:[~2022-09-10  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 18:24 [PATCH] staging: pi433: Fix string form declaration Burak Ozdemir
2022-09-09 18:04 ` Greg Kroah-Hartman
     [not found]   ` <CACAQkfXH4smoY2v28DOZ_0uf_2=e8iEDSFbEbTMhU0JPuteOPw@mail.gmail.com>
2022-09-10  5:36     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxwidHdwPz2yUAP4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bozdemir@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox