From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hao Peng <flyingpenghao@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>
Subject: Re: [PATCH] clocking-wizard: fix a schedule during spin lock acquisition
Date: Fri, 23 Sep 2022 18:29:01 +0300 [thread overview]
Message-ID: <Yy3Qvdvf7f2SL5Em@kadam> (raw)
In-Reply-To: <CAPm50a+XqKGBEQC-8iS_3amnphL4LVcOYhBeHqaC_P+Ld_ddhg@mail.gmail.com>
On Fri, Sep 23, 2022 at 10:53:27PM +0800, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> when the interrupt is disabled and the spin lock is acquired,
> calling read_poll_timeout will trigger the schedule, which should
> be replaced by read_poll_timeout_atomic.
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
> drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 39367712ef54..986af03b31c9 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -157,7 +157,7 @@ static int clk_wzrd_dynamic_reconfig(struct clk_hw
> *hw, unsigned long rate,
> writel(0x00, div_addr + WZRD_DR_DIV_TO_PHASE_OFFSET);
>
Your patch is corrupted and cannot be applied. Read the couple
paragraphs of Documentation/process/email-clients.rst for hints.
regards,
dan carpenter
next prev parent reply other threads:[~2022-09-23 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 14:53 [PATCH] clocking-wizard: fix a schedule during spin lock acquisition Hao Peng
2022-09-23 15:29 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-18 2:43 flyingpeng(彭浩)
2022-09-24 11:06 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy3Qvdvf7f2SL5Em@kadam \
--to=dan.carpenter@oracle.com \
--cc=flyingpenghao@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox