From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C755E80C for ; Sun, 18 Sep 2022 13:49:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE916C433D6; Sun, 18 Sep 2022 13:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663508965; bh=b9e71F3nMW7cIsiR4wi0l6hkI8dVVqpIwHBb+/eFsLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pCAlmFkDeRC+AmLbAAxtBpNPbWcnPkGwNCgwE8VlNrYfBSjlifMtSYS97q+/NKFkb B2LCGod2DxM7N4zUvoUX9FqCY3JMRKAbRPwqaS/rg0m3OnaT3r9L9CLNZZf/+xdG1k j/QPEamLZ4APABsLJ38uaHFQEdRbJnT8numeEEfk= Date: Sun, 18 Sep 2022 15:49:52 +0200 From: Greg Kroah-Hartman To: Valentin Vidic Cc: Philipp Hortmann , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: fix CamelCase struct member Message-ID: References: <20220918114926.3809060-1-vvidic@valentin-vidic.from.hr> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220918114926.3809060-1-vvidic@valentin-vidic.from.hr> On Sun, Sep 18, 2022 at 01:49:26PM +0200, Valentin Vidic wrote: > Fix checkpatch warnings for struct member pFirmware. > > Signed-off-by: Valentin Vidic > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++---- > drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++-- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 ++++---- > drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 +- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > index 4b9249195b5a..6308a25e064c 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > @@ -707,19 +707,19 @@ bool rtl92e_start_adapter(struct net_device *dev) > rtl92e_writeb(dev, ANAPAR, 0x37); > mdelay(500); > } > - priv->pFirmware->status = FW_STATUS_0_INIT; > + priv->pfirmware->status = FW_STATUS_0_INIT; What does "pfirmware" mean here? If you fix up camelcase warnings, please do so in a way that is the proper Linux kernel style, not just making everything lowercase. Look up Hungarian notation and why the original was named this way and why this isn't needed in Linux at all (i.e. we have modern compilers.) thanks, greg k-h