From: Dan Carpenter <dan.carpenter@oracle.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT_TRACE
Date: Mon, 19 Sep 2022 10:09:38 +0300 [thread overview]
Message-ID: <YygVsmIFlt4IQ/E4@kadam> (raw)
In-Reply-To: <cover.1663387785.git.philipp.g.hortmann@gmail.com>
On Sat, Sep 17, 2022 at 06:24:53AM +0200, Philipp Hortmann wrote:
> Remove "Unnecessary ftrace-like logging" as requested by checkpatch. To
> keep the logging would make future patches for fixing CamelCase larger.
>
> Tested with rtl8192e
> Transferred this patch over wlan connection of rtl8192e
>
Looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
When I'm reviewing a mass delete change like this, the typical bug that
I'm looking for is deleting extra lines by mistake. So I go through it
line by line and make sure nothing extra was deleted. It's not
complicated but it just takes a while to check.
This patchset will introduce some checkpatch warnings about extra
curly braces but I actually prefer if those are fixed in a separate
patch. It makes these easier to review. If you were just deleting
one RT_TRACE() call then doing it together is the correct thing but when
it's a mass delete I prefer the curly braces changes done as a separate
thing.
regards,
dan carpenter
prev parent reply other threads:[~2022-09-19 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 4:24 [PATCH 0/6] staging: rtl8192e: Remove ftrace-like logging RT_TRACE Philipp Hortmann
2022-09-17 4:25 ` [PATCH 1/6] staging: rtl8192e: Remove ftrace-like logging in r8192E_firmware.c, Philipp Hortmann
2022-09-17 4:25 ` [PATCH 2/6] staging: rtl8192e: Remove ftrace-like logging in r8192E_dev.c Philipp Hortmann
2022-09-17 4:25 ` [PATCH 3/6] staging: rtl8192e: Remove ftrace-like logging in r8192E_phy.c Philipp Hortmann
2022-09-17 4:25 ` [PATCH 4/6] staging: rtl8192e: Remove ftrace-like logging in rtl_dm.c Philipp Hortmann
2022-09-17 4:25 ` [PATCH 5/6] staging: rtl8192e: Remove ftrace-like logging in rtl_ps.c Philipp Hortmann
2022-09-17 4:25 ` [PATCH 6/6] staging: rtl8192e: Remove ftrace-like logging in rtl819x_BAProc.c, Philipp Hortmann
2022-09-19 7:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YygVsmIFlt4IQ/E4@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox