* Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment
2022-09-17 18:11 [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment Kang Minchul
@ 2022-09-17 19:38 ` Hans de Goede
2022-09-19 8:48 ` Dan Carpenter
2022-09-19 9:09 ` Greg Kroah-Hartman
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2022-09-17 19:38 UTC (permalink / raw)
To: Kang Minchul, Greg Kroah-Hartman
Cc: Fabio Aiuto, Kees Cook, linux-staging, linux-kernel
Hi,
On 9/17/22 20:11, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
>
>
>
>
> /*
> -caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> -pframequeue: defrag_queue : will be accessed in recv_thread (passive)
> -
> -using spinlock to protect
> -
> -*/
> + * caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> + * pframequeue: defrag_queue : will be accessed in recv_thread (passive)
> + *
> + * using spinlock to protect
> + *
> + */
>
> void rtw_free_recvframe_queue(struct __queue *pframequeue, struct __queue *pfree_recv_queue)
> {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment
2022-09-17 18:11 [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment Kang Minchul
2022-09-17 19:38 ` Hans de Goede
@ 2022-09-19 8:48 ` Dan Carpenter
2022-09-19 9:09 ` Greg Kroah-Hartman
2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2022-09-19 8:48 UTC (permalink / raw)
To: Kang Minchul
Cc: Greg Kroah-Hartman, Hans de Goede, Fabio Aiuto, Kees Cook,
linux-staging, linux-kernel
On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
Just delete this dead code.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment
2022-09-17 18:11 [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment Kang Minchul
2022-09-17 19:38 ` Hans de Goede
2022-09-19 8:48 ` Dan Carpenter
@ 2022-09-19 9:09 ` Greg Kroah-Hartman
2022-09-19 13:38 ` Kang Minchul
2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-19 9:09 UTC (permalink / raw)
To: Kang Minchul
Cc: Hans de Goede, Fabio Aiuto, Kees Cook, linux-staging,
linux-kernel
On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
I agree with Dan, just remove these unused functions please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment
2022-09-19 9:09 ` Greg Kroah-Hartman
@ 2022-09-19 13:38 ` Kang Minchul
0 siblings, 0 replies; 5+ messages in thread
From: Kang Minchul @ 2022-09-19 13:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Hans de Goede, Fabio Aiuto, Kees Cook, linux-staging,
linux-kernel
Thank you for your feedback!
I just amended and re-submitted the patch.
Thank you.
Kang
2022년 9월 19일 (월) 오후 6:09, Greg Kroah-Hartman <gregkh@linuxfoundation.org>님이 작성:
>
> On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> > This patch removes the following warning generated by checkpatch.pl
> >
> > WARNING: Block comments use * on subsequent lines
> > #206: FILE: rtw_recv.c:206:
> > +/*
> > +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> >
> > WARNING: Block comments use * on subsequent lines
> > #216: FILE: rtw_recv.c:216:
> > +/*
> > +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> >
> > Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > index d8d394b67eeb..ad6fb6c3d1f0 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> > }
> >
> > /*
> > -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> > -{
> > - return rtw_free_recvframe(precvframe, queue);
> > -}
> > -*/
> > + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> > + * {
> > + * return rtw_free_recvframe(precvframe, queue);
> > + * }
> > + */
>
> I agree with Dan, just remove these unused functions please.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread