From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kang Minchul <tegongkang@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Fabio Aiuto <fabioaiuto83@gmail.com>,
Kees Cook <keescook@chromium.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment
Date: Mon, 19 Sep 2022 11:09:48 +0200 [thread overview]
Message-ID: <Yygx3M4ALtIpWbu7@kroah.com> (raw)
In-Reply-To: <20220917181130.3237159-1-tegongkang@gmail.com>
On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
I agree with Dan, just remove these unused functions please.
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-19 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 18:11 [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment Kang Minchul
2022-09-17 19:38 ` Hans de Goede
2022-09-19 8:48 ` Dan Carpenter
2022-09-19 9:09 ` Greg Kroah-Hartman [this message]
2022-09-19 13:38 ` Kang Minchul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yygx3M4ALtIpWbu7@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fabioaiuto83@gmail.com \
--cc=hdegoede@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tegongkang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox