Re: [PATCH v2 1/3] staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted

Greg KH
2025-04-04T08:02:26Z

On Fri, Apr 04, 2025 at 09:58:23AM +0300, Erick Karanja wrote:
> On Wed, 2025-04-02 at 21:41 +0100, Greg KH wrote:
> > On Wed, Apr 02, 2025 at 10:34:22PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Wed, 2 Apr 2025, Greg KH wrote:
> > >
> > > > On Wed, Apr 02, 2025 at 08:16:42PM +0300, Erick Karanja wrote:
> > > > > Standardize boolean representation by ensuring consistency,
> > > > > replace instances of 1/0 with true/false where boolean logic is
> > > > > implied,
> > > > > as some definitions already use true/false.
> > > > > This improves code clarity and aligns with the kernel’s bool
> > > > > type usage.
> > > > >
> > > > > Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> > > > > ---
> > > > >  drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > > > > b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > > > > index a389ba5ecc6f..fd04dbacb50f 100644
> > > > > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > > > > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > > > > @@ -1358,7 +1358,7 @@ static signed int
> > > > > validate_80211w_mgmt(struct adapter *adapter, union recv_frame
> > > > >   u8 *mgmt_DATA;
> > > > >   u32 data_len = 0;
> > > > >
> > > > > - pattrib->bdecrypted = 0;
> > > > > + pattrib->bdecrypted = false;
> > > >
> > > > but bdecrypted is a u8, not a boolean type.  So setting it to
> > > > "false"
> > > > does not seem correct here, right?
> > >
> > > Is false different than 0?
> >
> > Does C guarantee that?  I can never remember.  I don't think it
> > guarantees that a 'bool' will only be 8 bits, or am I mistaken there
> > too?
> >
> > > Elsewhere there is an assignment to true.
> >
> > Was that in the original driver?
> >
> > If this doesn't come from the hardware, then it's fine to make the
> > change.  If it does, it needs to be verified that the layout and bit
> > values are identical.
> >
> > thanks,
> I have compared the generated assembly code
> before and after and I have observed the only
> change is the comment below.
> -# drivers/staging/rtl8723bs/core/rtw_recv.c:1361:
> pattrib->bdecrypted = 0;
> +# drivers/staging/rtl8723bs/core/rtw_recv.c:1361:
> pattrib->bdecrypted = false;
> There is no change in the assembly instructions.

Showing the assembly is key, not just a comment :)