[PATCH v2 2/3] staging: media: Remove duplicated NULL tests on a value in av7110

Abraham Samuel Adekunle
2025-04-03T13:27:43Z

When a value has been tested for NULL in an expression, a
second NULL test on the same value in another expression
is unnecessary when the value has not been assigned NULL.

Remove unnecessary duplicate NULL tests on the same value that
has previously been NULL tested.

Found by Coccinelle

Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
---
drivers/staging/media/av7110/sp8870.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
index 0c813860f5b2..65842dd559e3 100644
--- a/drivers/staging/media/av7110/sp8870.c
+++ b/drivers/staging/media/av7110/sp8870.c
@@ -508,12 +508,10 @@ static int sp8870_set_frontend(struct dvb_frontend *fe)
}

if (debug) {
- if (valid) {
- if (trials > 1) {
- pr_info("%s(): firmware lockup!!!\n", __func__);
- pr_info("%s(): recovered after %i trial(s))\n", __func__, trials - 1);
- lockups++;
- }
+ if (trials > 1) {
+ pr_info("%s(): firmware lockup!!!\n", __func__);
+ pr_info("%s(): recovered after %i trial(s))\n", __func__, trials - 1);
+ lockups++;
}
switches++;
pr_info("%s(): switches = %i lockups = %i\n", __func__, switches, lockups);
--
2.34.1