Re: [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci

Hans de Goede
2025-05-01T14:16:43Z

Hi,

On 3-Apr-25 3:26 PM, Abraham Samuel Adekunle wrote:
> When a value has been tested for NULL in an expression, a
> second NULL test on the same value in another expression
> is unnecessary when the value has not been assigned NULL.
>
> Remove unnecessary duplicate NULL tests on the same value that
> has previously been NULL tested.
>
> Found by Coccinelle
>
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans

> ---
> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index e176483df301..0abac820299a 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1292,7 +1292,7 @@ static int gmin_get_config_dsm_var(struct device *dev,
> * if it founds something different than string, letting it
> * to fall back to the old code.
> */
> - if (cur && cur->type != ACPI_TYPE_STRING) {
> + if (cur->type != ACPI_TYPE_STRING) {
> dev_info(dev, "found non-string _DSM entry for '%s'\n", var);
> ACPI_FREE(obj);
> return -EINVAL;