From: Dave Penkler <dpenkler@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Antonio Riccio <linux@ariccio.me>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Rename variable ValidAll
Date: Sun, 22 Dec 2024 10:19:28 +0100 [thread overview]
Message-ID: <Z2fZoGCf6WGUunGI@egonzo> (raw)
In-Reply-To: <2024122201-uncivil-footnote-f584@gregkh>
On Sun, Dec 22, 2024 at 07:11:40AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Dec 21, 2024 at 08:01:23PM +0000, Antonio Riccio wrote:
> > --- a/drivers/staging/gpib/uapi/gpib_user.h
> > +++ b/drivers/staging/gpib/uapi/gpib_user.h
> > @@ -114,7 +114,7 @@ enum bus_control_line {
> > ValidSRQ = 0x20,
> > ValidATN = 0x40,
> > ValidEOI = 0x80,
> > - ValidALL = 0xff,
> > + VALIDALL = 0xff,
>
> Why are you only changing one of these? And are you sure that these
> values aren't coming from a specification with this type of naming?
>
> thanks,
>
> greg k-h
I prefer that we keep the camel case definitions in the uapi includes
as they are for now so that they remain compatible with the current
user space includes. Over time I will release a version of the user
space includes that provide compatability definitions for the
checkpatch clean version of the uapi includes. This includes the camel
case definitions and the typedefs. I will submit a patches for this in
the new year.
-dave
next prev parent reply other threads:[~2024-12-22 9:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 20:01 [PATCH] staging: gpib: Rename variable ValidAll Antonio Riccio
2024-12-22 6:11 ` Greg Kroah-Hartman
2024-12-22 9:19 ` Dave Penkler [this message]
2024-12-22 9:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2fZoGCf6WGUunGI@egonzo \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@ariccio.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox