From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEDE31FF60F; Mon, 27 Jan 2025 13:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737984331; cv=none; b=ftbI7iVt3e+DnsELGXNoebxH8Jm6yzOlxPrOgt5nljdP9ZBVeGoIzaAH+d4Ea1vKppGJgAwiVVCJW5OxiQQhpcv/QeEI2auDVhkeLaJ2+8DfZBxGLaagqawbnkB8J8JeexnY5cJelNksglNC+dV03JtiuIAxNCUrPeOWpQ0xe7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737984331; c=relaxed/simple; bh=RjFj+btLOrA1I0c/0XDEPot6dd9rNyckywxmgkJzq3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QY1HaSC+tcqkRu16uCdXF39TDHwhZxP/RUVWHFe5g7CshiLGX82kYTkNsCdeGTROYWqjmlThPqSz2fO8JVIRFVs9lAKMmvJRhjWNo37kyVL+oTX1ddKyauCUJ7DA8kANbAJ25HMreryqFqq6ri+oZOBLQm0bjzatcgsN8Ky8zLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=c4TphOHn; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="c4TphOHn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737984329; x=1769520329; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RjFj+btLOrA1I0c/0XDEPot6dd9rNyckywxmgkJzq3o=; b=c4TphOHnOc6wrt2+smoGshV7o6p9F15alON/EAq8PJ9nPfbZ03eYHLE0 LYEzkqP7sUu1f+2XxTk/YsB9lnpxeEF47VM6CUyO+9OW3IMs1Kawc/NFa 8YAxQTeA2bfAwhdxu5fS0sAmFL+70H5LHFcLwKMXCMm3q0wo3f2YM+rnS 2smR6qVdZbEekuIHYXyn7CVaFjL+tPhRIxEiurTqCD/obnKOS6wOFFwuK 7xAaPlJ2FXdQNs3dbJNsiLAgc8fy/HnuvaSw+ixLvP6ElLLr0i77w2/ZQ qZ9uCGjnqRBmH8v/E0VyKAgUV2U7XeG6qaZBDUUPhEZPxf2/dU1HrgRoi Q==; X-CSE-ConnectionGUID: hnQP/NfES8C1CqTjUlYg3g== X-CSE-MsgGUID: HGeRKCaCRVicLpUxN+FMag== X-IronPort-AV: E=McAfee;i="6700,10204,11328"; a="42105370" X-IronPort-AV: E=Sophos;i="6.13,238,1732608000"; d="scan'208";a="42105370" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2025 05:25:22 -0800 X-CSE-ConnectionGUID: oOw//HyuRH2sXbDiVD3/cA== X-CSE-MsgGUID: F7vXYkyrSx2N1gt4t3xT9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="131730368" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2025 05:25:02 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tcP6l-00000005jpm-3fIe; Mon, 27 Jan 2025 15:24:55 +0200 Date: Mon, 27 Jan 2025 15:24:55 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Michael Ellerman , Christophe Leroy , Damien Le Moal , Jiri Kosina , Greg Kroah-Hartman , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Tero Kristo , Stephen Boyd , Ian Abbott , H Hartley Sweeten , Srinivas Pandruvada , Len Brown , "Rafael J. Wysocki" , John Allen , Herbert Xu , Vinod Koul , Ard Biesheuvel , Bjorn Andersson , Moritz Fischer , Liviu Dudau , Benjamin Tissoires , Andi Shyti , Michael Hennerich , Peter Rosin , Lars-Peter Clausen , Jonathan Cameron , Dmitry Torokhov , Markuss Broks , Alexandre Torgue , Lee Jones , Jakub Kicinski , Shyam Sundar S K , Iyappan Subramanian , Yisen Zhuang , Stanislaw Gruszka , Kalle Valo , Sebastian Reichel , Tony Lindgren , Mark Brown , Alexandre Belloni , Xiang Chen , "Martin K. Petersen" , Neil Armstrong , Heiko Stuebner , Krzysztof Kozlowski , Vaibhav Hiremath , Alex Elder , Jiri Slaby , Jacky Huang , Helge Deller , Christoph Hellwig , Robin Murphy , Steven Rostedt , Masami Hiramatsu , Andrew Morton , Kees Cook , Trond Myklebust , Anna Schumaker , Masahiro Yamada , Nathan Chancellor , Takashi Iwai , linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fpga@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-leds@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rtc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, iommu@lists.linux.dev, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-hardening@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kbuild@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 00/34] address all -Wunused-const warnings Message-ID: References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 03, 2024 at 10:06:18AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compilers traditionally warn for unused 'static' variables, but not > if they are constant. The reason here is a custom for C++ programmers > to define named constants as 'static const' variables in header files > instead of using macros or enums. > > In W=1 builds, we get warnings only static const variables in C > files, but not in headers, which is a good compromise, but this still > produces warning output in at least 30 files. These warnings are > almost all harmless, but also trivial to fix, and there is no > good reason to warn only about the non-const variables being unused. > > I've gone through all the files that I found using randconfig and > allmodconfig builds and created patches to avoid these warnings, > with the goal of retaining a clean build once the option is enabled > by default. > > Unfortunately, there is one fairly large patch ("drivers: remove > incorrect of_match_ptr/ACPI_PTR annotations") that touches > 34 individual drivers that all need the same one-line change. > If necessary, I can split it up by driver or by subsystem, > but at least for reviewing I would keep it as one piece for > the moment. > > Please merge the individual patches through subsystem trees. > I expect that some of these will have to go through multiple > revisions before they are picked up, so anything that gets > applied early saves me from resending. Arnd, can you refresh this one? It seems some misses still... I have got 3+ 0-day reports against one of the mux drivers. https://lore.kernel.org/all/?q=adg792a.c -- With Best Regards, Andy Shevchenko