public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Dave Penkler <dpenkler@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Ian To <onlyian4981@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: format no multiple blank lines
Date: Mon, 3 Feb 2025 16:35:55 +0100	[thread overview]
Message-ID: <Z6DiWyufORWca-4T@egonzo> (raw)
In-Reply-To: <2025020335-impromptu-renewable-83e8@gregkh>

On Mon, Feb 03, 2025 at 04:09:45PM +0100, Greg KH wrote:
> On Fri, Jan 31, 2025 at 12:22:33AM -0800, Ian To wrote:
> > Avoid adding multiple blank lines. Reported by checkpatch.
> > 
> > Signed-off-by: Ian To <onlyian4981@gmail.com>
> > ---
> >  drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gpib/hp_82341/hp_82341.h b/drivers/staging/gpib/hp_82341/hp_82341.h
> > index 0065ebd9747c..d3cf1f43a1ef 100644
> > --- a/drivers/staging/gpib/hp_82341/hp_82341.h
> > +++ b/drivers/staging/gpib/hp_82341/hp_82341.h
> > @@ -26,7 +26,6 @@ struct hp_82341_priv {
> >  	enum hp_82341_hardware_version hw_version;
> >  };
> >  
> > -
> >  // interface functions
> >  int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
> >  			size_t *bytes_read);
> > -- 
> > 2.45.3
> > 
> > 
> 
> Does not apply cleanly to 6.14-rc1 :(
An earlier patch, commit 8418753187ba ("staging: gpib: Make static, reduce fwd declarations") changed this file. It is at this point checkpatch clean.
cheers,
-dave

      reply	other threads:[~2025-02-03 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-31  8:22 [PATCH] staging: gpib: format no multiple blank lines Ian To
2025-02-03 15:09 ` Greg KH
2025-02-03 15:35   ` Dave Penkler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6DiWyufORWca-4T@egonzo \
    --to=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=onlyian4981@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox