Re: [PATCH 1/3] media: cx231xx: Convert enum into a define

Hans Verkuil
2025-02-20T15:12:44Z

On 2/20/25 15:06, Andy Shevchenko wrote:
> On Thu, Feb 20, 2025 at 02:55:42PM +0100, Hans Verkuil wrote:
>> On 12/3/24 09:31, Mauro Carvalho Chehab wrote:
>
> ...
>
>> ORing enums is really not a good idea: you would normally never do that, and
>
> I think you missed a keyword "different", so "ORing different enums ..."
> which I totally agree on, but the same enum values are fine.

While the compiler might be happy with that, I think ORing enums regardless
is weird. It's not what enums are for.

Regards,

Hans

>
>> the compiler warning is IMHO appropriate.
>