Re: [PATCH v1 00/20] Removing typedef for gpib_board

Dave Penkler
2025-03-20T08:18:05Z

On Wed, Mar 19, 2025 at 09:59:04PM +0000, Michael Rubin wrote:
> staging: gpib: Removing typedef for gpib_board
>
> Adhering to Linux code style.
>
> In general, a pointer, or a struct that has elements that can reasonably be
> directly accessed should never be a typedef.
>
> * Patch 1: struct typing for gpib_board
>
> Introduces struct gpib_board replacing gpib_board_t
>
> * Patch 2 - Patch 18
>
> Adopting "struct gpib_board" as opposed to "gpib_board_t" for each
> subsystem in gpib.
>
> * staging: gpib: agilent_82350b: struct gpib_board
> * staging: gpib: agilent_82357a: struct gpib_board
> * staging: gpib: cb7210: struct gpib_board
> * staging: gpib: cec_gpib: struct gpib_board
> * staging: gpib: common: struct gpib_board
> * staging: gpib: eastwood: struct gpib_board
> * staging: gpib: fmh_gpib: struct gpib_board
> * staging: gpib: gpio: struct gpib_board
> * staging: gpib: hp2335: struct gpib_board
> * staging: gpib: hp_82341: struct gpib_board
> * staging: gpib: ines: struct gpib_board
> * staging: gpib: lpvo_usb_gpib: struct gpib_board
> * staging: gpib: nec7210 struct gpib_board
> * staging: gpib: ni_usb_gpib: struct gpib_board
> * staging: gpib: pc2: struct gpib_board
> * staging: gpib: tms9914: struct gpib_board
> * staging: gpib: tnt4882: struct gpib_board
>
> * Patch 19: staging: gpib: struct typing for gpib_gboard_t
>
> Adopting "struct gbip_board" as opposed to "gpib_board_t" for include files.
>
> * Patch 20: staging: gpib: Removing typedef for gpib_board
>
> Removing typedef for gpib_board_t
>
> Michael Rubin (20):
> staging: gpib: struct typing for gpib_board
> staging: gpib: agilent_82350b: struct gpib_board
> staging: gpib: agilent_82357a: struct gpib_board
> staging: gpib: cb7210: struct gpib_board
> staging: gpib: cec_gpib: struct gpib_board
> staging: gpib: common: struct gpib_board
> staging: gpib: eastwood: struct gpib_board
> staging: gpib: fmh_gpib: struct gpib_board
> staging: gpib: gpio: struct gpib_board
> staging: gpib: hp2335: struct gpib_board
> staging: gpib: hp_82341: struct gpib_board
> staging: gpib: ines: struct gpib_board
> staging: gpib: lpvo_usb_gpib: struct gpib_board
> staging: gpib: nec7210 struct gpib_board
> staging: gpib: ni_usb_gpib: struct gpib_board
> staging: gpib: pc2: struct gpib_board
> staging: gpib: tms9914: struct gpib_board
> staging: gpib: tnt4882: struct gpib_board
> staging: gpib: struct typing for gpib_gboard_t
> staging: gpib: Removing typedef for gpib_board
>
> .../gpib/agilent_82350b/agilent_82350b.c | 99 +++++----
> .../gpib/agilent_82357a/agilent_82357a.c | 85 ++++----
> drivers/staging/gpib/cb7210/cb7210.c | 107 +++++-----
> drivers/staging/gpib/cec/cec_gpib.c | 59 +++---
> drivers/staging/gpib/common/gpib_os.c | 196 +++++++++---------
> drivers/staging/gpib/common/iblib.c | 50 ++---
> drivers/staging/gpib/common/ibsys.h | 14 +-
> drivers/staging/gpib/eastwood/fluke_gpib.c | 93 +++++----
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 122 +++++------
> drivers/staging/gpib/gpio/gpib_bitbang.c | 72 +++----
> drivers/staging/gpib/hp_82335/hp82335.c | 56 ++---
> drivers/staging/gpib/hp_82341/hp_82341.c | 68 +++---
> drivers/staging/gpib/include/gpibP.h | 10 +-
> drivers/staging/gpib/include/gpib_proto.h | 58 +++---
> drivers/staging/gpib/include/gpib_types.h | 58 +++---
> drivers/staging/gpib/include/nec7210.h | 58 +++---
> drivers/staging/gpib/include/tms9914.h | 52 ++---
> drivers/staging/gpib/ines/ines.h | 54 ++---
> drivers/staging/gpib/ines/ines_gpib.c | 111 +++++-----
> .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 66 +++---
> drivers/staging/gpib/nec7210/nec7210.c | 76 +++----
> drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 70 +++----
> drivers/staging/gpib/pc2/pc2_gpib.c | 68 +++---
> drivers/staging/gpib/tms9914/tms9914.c | 66 +++---
> drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 100 ++++-----
> 25 files changed, 947 insertions(+), 921 deletions(-)
>
> --
> 2.43.0
>
Acked-By: Dave Penkler <dpenkler@gmail.com>