public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Pavel Skripkin <paskripkin@gmail.com>,
	Michael Straube <straube.linux@gmail.com>,
	Jes Sorensen <Jes.Sorensen@gmail.com>,
	Bastien Nocera <hadess@hadess.net>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-staging@lists.linux.dev
Subject: Re: the future of r8188eu (was: Re: [PATCH 1/2] staging: rtl8723bs: Fix key-store index handling)
Date: Wed, 8 Mar 2023 15:51:16 +0100	[thread overview]
Message-ID: <ZAig5NgrnB+xnbHk@kroah.com> (raw)
In-Reply-To: <ZAgsE210Cna2hGet@kroah.com>

On Wed, Mar 08, 2023 at 07:32:51AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 07, 2023 at 09:40:10PM +0100, Martin Kaiser wrote:
> > Hi all,
> > 
> > Thus wrote Hans de Goede (hdegoede@redhat.com):
> > 
> > > Note I have heard that the r8188eu is now (starting with 6.2 ?) supported
> > > by one of the non staging realtek wifi drivers. So I think that maybe it
> > > can just be removed from staging altogether ?
> > 
> > thanks for bringing this up.
> > 
> > Indeed, the r8xxxu driver does now support the rtl8188eu chipset. The
> > code for this chip has landed in Linus' tree for 6.3-rc1.
> > 
> > The r8xxxu driver uses mac80211 and seems to work well (at least for
> > me). The Kconfig entry says that features like power management are
> > missing, this is supported by r8188eu.
> > 
> > So this raises the question about the future of r8188eu. It might have
> > more features, which are probably not well tested, but its integration
> > into the rest of the kernel is far behind rtl8xxxu. A lot of people (myself
> > included) have submitted cleanups for r8188eu and improved it. Still,
> > when 6.3 is released, it's likely that the users of rtl8188eu-based
> > dongles will switch to rtl8xxxu.
> > 
> > I guess we might have to bite the bullet and give up on r8188eu...
> > 
> > What do you think?
> 
> Yes, we need to drop the staging driver if there is a "real" kernel
> driver that supports the same hardware.  We can't have multiple drivers
> in the kernel that try to bind to the same device, we've done that in
> the past and it causes nothing but problems.
> 
> I'll go make up a patch now to drop the staging driver, thanks for
> letting me know.

For those that didn't see it, the patch that removes the staging driver
is here:
	https://lore.kernel.org/r/20230308131934.380395-1-gregkh@linuxfoundation.org


      reply	other threads:[~2023-03-08 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 15:35 [PATCH 1/2] staging: rtl8723bs: Fix key-store index handling Hans de Goede
2023-03-06 15:35 ` [PATCH 2/2] staging: rtl8723bs: Pass correct parameters to cfg80211_get_bss() Hans de Goede
2023-03-06 15:40 ` [PATCH 1/2] staging: rtl8723bs: Fix key-store index handling Bastien Nocera
2023-03-07 10:26   ` Hans de Goede
2023-03-07 20:40     ` the future of r8188eu (was: Re: [PATCH 1/2] staging: rtl8723bs: Fix key-store index handling) Martin Kaiser
2023-03-08  6:32       ` Greg Kroah-Hartman
2023-03-08 14:51         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAig5NgrnB+xnbHk@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jes.Sorensen@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=paskripkin@gmail.com \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox