From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C842747F for ; Wed, 8 Mar 2023 14:51:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB3AEC4339B; Wed, 8 Mar 2023 14:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678287079; bh=IUjjXsXa4VFMAmLEyYbWEsSh8J1s+8i+V7CvTjCRccw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V9og2zP+hWZLjIAYG2tHoT2wNPvuowiDt8s8C0zpTWGFt7xYpZQvSRog6aIFaTysr bzAiUteUUnQtoe09hncR38hnetpT2nYnyuh/u5APmDuNMbMG9y76DmZhjoMG3yhd4i DIKj1sX0Cn+lcdIODNL7VcejSCLPKLIQrXCF88NQ= Date: Wed, 8 Mar 2023 15:51:16 +0100 From: Greg Kroah-Hartman To: Martin Kaiser Cc: Larry Finger , Phillip Potter , Pavel Skripkin , Michael Straube , Jes Sorensen , Bastien Nocera , Hans de Goede , linux-staging@lists.linux.dev Subject: Re: the future of r8188eu (was: Re: [PATCH 1/2] staging: rtl8723bs: Fix key-store index handling) Message-ID: References: <20230306153512.162104-1-hdegoede@redhat.com> <3a17dd23-c396-7cfb-3cfa-19cdec39f2ff@redhat.com> <20230307204010.xl6s5wka2izoncbm@viti.kaiser.cx> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 08, 2023 at 07:32:51AM +0100, Greg Kroah-Hartman wrote: > On Tue, Mar 07, 2023 at 09:40:10PM +0100, Martin Kaiser wrote: > > Hi all, > > > > Thus wrote Hans de Goede (hdegoede@redhat.com): > > > > > Note I have heard that the r8188eu is now (starting with 6.2 ?) supported > > > by one of the non staging realtek wifi drivers. So I think that maybe it > > > can just be removed from staging altogether ? > > > > thanks for bringing this up. > > > > Indeed, the r8xxxu driver does now support the rtl8188eu chipset. The > > code for this chip has landed in Linus' tree for 6.3-rc1. > > > > The r8xxxu driver uses mac80211 and seems to work well (at least for > > me). The Kconfig entry says that features like power management are > > missing, this is supported by r8188eu. > > > > So this raises the question about the future of r8188eu. It might have > > more features, which are probably not well tested, but its integration > > into the rest of the kernel is far behind rtl8xxxu. A lot of people (myself > > included) have submitted cleanups for r8188eu and improved it. Still, > > when 6.3 is released, it's likely that the users of rtl8188eu-based > > dongles will switch to rtl8xxxu. > > > > I guess we might have to bite the bullet and give up on r8188eu... > > > > What do you think? > > Yes, we need to drop the staging driver if there is a "real" kernel > driver that supports the same hardware. We can't have multiple drivers > in the kernel that try to bind to the same device, we've done that in > the past and it causes nothing but problems. > > I'll go make up a patch now to drop the staging driver, thanks for > letting me know. For those that didn't see it, the patch that removes the staging driver is here: https://lore.kernel.org/r/20230308131934.380395-1-gregkh@linuxfoundation.org