* [PATCH] staging: fbtft: fixes alignment should match open parenthesis
@ 2023-03-10 4:01 Kloudifold
2023-03-10 4:07 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Kloudifold @ 2023-03-10 4:01 UTC (permalink / raw)
To: gregkh, outreachy, linux-staging; +Cc: linux-kernel
This patch fixes the checks reported by checkpatch.pl
for alignment should match open parenthesis
Signed-off-by: Kloudifold <cloudifold.3125@gmail.com>
---
drivers/staging/fbtft/fb_tinylcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2..7d4741c47 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -37,8 +37,8 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xB3, 0x00);
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
- write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00,
+ 0x00, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fbtft: fixes alignment should match open parenthesis
2023-03-10 4:01 [PATCH] staging: fbtft: fixes alignment should match open parenthesis Kloudifold
@ 2023-03-10 4:07 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-03-10 4:07 UTC (permalink / raw)
To: Kloudifold; +Cc: gregkh, outreachy, linux-staging, linux-kernel
On Fri, Mar 10, 2023 at 12:01:21PM +0800, Kloudifold wrote:
> This patch fixes the checks reported by checkpatch.pl
> for alignment should match open parenthesis
>
> Signed-off-by: Kloudifold <cloudifold.3125@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2..7d4741c47 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -37,8 +37,8 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xB3, 0x00);
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> - write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00,
> + 0x00, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
The original was obviously deliberate. Just leave it as-is. Checkpatch
is not the king of the world.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-10 4:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 4:01 [PATCH] staging: fbtft: fixes alignment should match open parenthesis Kloudifold
2023-03-10 4:07 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox