From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: outreachy@lists.linux.dev,
Vaibhav Hiremath <hvaibhav.linux@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus: remove tabs to fix line length and merge lines
Date: Sat, 11 Mar 2023 11:24:20 +0500 [thread overview]
Message-ID: <ZAwelPOv45zThK6j@khadija-virtual-machine> (raw)
In-Reply-To: <6e9fd119-6566-4778-899e-bc5a7ee7830c@kili.mountain>
On Sat, Mar 11, 2023 at 07:16:19AM +0300, Dan Carpenter wrote:
> On Sat, Mar 11, 2023 at 03:18:04AM +0500, Khadija Kamran wrote:
> > In file drivers/staging/greybus/arche-platform.c,
> > - Length of line 181 exceeds 100 columns, fix by removing tabs from the
> > line.
> > - If condition and spin_unlock_...() call is split into two lines, join
> > them to form a single line.
> >
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> > Changes in v2:
> > - Change the subject and log message
> > - Merge if condition and spin_unlock...() from two lines to one
>
> Apply your patch and then re-run checkpatch.pl -f on the file. You will
> see the problem.
Hey Dan!
When I run checkpatch.pl on my file, I can see that my old CHECK no
longer exists instead a new CHECK is mentioned saying 'Alignment should
match open parenthesis'. I understand this from your previous email.
Should I stop working on this file and leave it as is?
Thank you!
>
> regards,
> dan carpenter
next prev parent reply other threads:[~2023-03-11 6:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:18 [PATCH v2] staging: greybus: remove tabs to fix line length and merge lines Khadija Kamran
2023-03-11 4:16 ` Dan Carpenter
2023-03-11 6:24 ` Khadija Kamran [this message]
2023-03-11 7:05 ` Deepak R Varma
2023-03-11 7:16 ` Khadija Kamran
2023-03-11 8:48 ` Julia Lawall
2023-03-13 1:01 ` Ira Weiny
2023-03-20 8:53 ` Khadija Kamran
2023-03-21 0:33 ` Ira Weiny
2023-03-21 17:00 ` Khadija Kamran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAwelPOv45zThK6j@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=elder@kernel.org \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox