From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: outreachy@lists.linux.dev
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: fix line ending with '('
Date: Tue, 21 Mar 2023 21:19:27 +0500 [thread overview]
Message-ID: <ZBnZD5alylOgjhYd@khadija-virtual-machine> (raw)
In-Reply-To: <ZBhNOkQbG4ygNF98@khadija-virtual-machine>
On Mon, Mar 20, 2023 at 05:10:40PM +0500, Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the first parameter right after the '(' in the function call line.
> Align the rest of the parameters to the opening parenthesis.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> drivers/staging/greybus/audio_topology.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 62d7674852be..08e6a807c132 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {
> struct gb_audio_ctl_elem_info *info;
> };
>
> -static struct gbaudio_module_info *find_gb_module(
> - struct gbaudio_codec_info *codec,
> - char const *name)
> +static struct gbaudio_module_info *find_gb_module(struct gbaudio_codec_info *codec,
> + char const *name)
> {
> int dev_id;
> char begin[NAME_SIZE];
> --
> 2.34.1
>
Hey Outreachy Mentors,
Kindly take a look at this patch and let me know if I should wait for
the response on this patch or submit another patch.
Thank you for your time.
Regards,
Khadija
next prev parent reply other threads:[~2023-03-21 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 12:10 [PATCH] staging: greybus: fix line ending with '(' Khadija Kamran
2023-03-21 16:19 ` Khadija Kamran [this message]
2023-03-21 16:23 ` Greg Kroah-Hartman
2023-03-21 16:28 ` Khadija Kamran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBnZD5alylOgjhYd@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox