[PATCH] staging: greybus: fix line ending with '('

[PATCH] staging: greybus: fix line ending with '('

[Khadija Kamran]

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the first parameter right after the '(' in the function call line.
Align the rest of the parameters to the opening parenthesis.

Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
---
 drivers/staging/greybus/audio_topology.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
index 62d7674852be..08e6a807c132 100644
--- a/drivers/staging/greybus/audio_topology.c
+++ b/drivers/staging/greybus/audio_topology.c
@@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {
 	struct gb_audio_ctl_elem_info *info;
 };

-static struct gbaudio_module_info *find_gb_module(
-					struct gbaudio_codec_info *codec,
-					char const *name)
+static struct gbaudio_module_info *find_gb_module(struct gbaudio_codec_info *codec,
+						  char const *name)
 {
 	int dev_id;
 	char begin[NAME_SIZE];
--
2.34.1

Re: [PATCH] staging: greybus: fix line ending with '('

[Khadija Kamran]

On Mon, Mar 20, 2023 at 05:10:40PM +0500, Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
> 
> Move the first parameter right after the '(' in the function call line.
> Align the rest of the parameters to the opening parenthesis.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/greybus/audio_topology.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c
> index 62d7674852be..08e6a807c132 100644
> --- a/drivers/staging/greybus/audio_topology.c
> +++ b/drivers/staging/greybus/audio_topology.c
> @@ -24,9 +24,8 @@ struct gbaudio_ctl_pvt {
>  	struct gb_audio_ctl_elem_info *info;
>  };
> 
> -static struct gbaudio_module_info *find_gb_module(
> -					struct gbaudio_codec_info *codec,
> -					char const *name)
> +static struct gbaudio_module_info *find_gb_module(struct gbaudio_codec_info *codec,
> +						  char const *name)
>  {
>  	int dev_id;
>  	char begin[NAME_SIZE];
> --
> 2.34.1
>

Hey Outreachy Mentors,

Kindly take a look at this patch and let me know if I should wait for
the response on this patch or submit another patch.

Thank you for your time.
Regards,
Khadija

Re: [PATCH] staging: greybus: fix line ending with '('

[Greg Kroah-Hartman]

On Tue, Mar 21, 2023 at 09:19:27PM +0500, Khadija Kamran wrote:

<snip>

> Hey Outreachy Mentors,
> 
> Kindly take a look at this patch and let me know if I should wait for
> the response on this patch or submit another patch.

Less than 1 day later?

Please relax and always keep working on new things, don't let my
response time be the gateway for you doing work, otherwise you are not
going to get very much done at all.

You normally have to wait about 2 weeks to get a patch reviewed,
sometimes I go much faster, sometimes slower.  Either way, it's
uncertian...

thanks,

greg k-h

Re: [PATCH] staging: greybus: fix line ending with '('

[Khadija Kamran]

On Tue, Mar 21, 2023 at 05:23:23PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 21, 2023 at 09:19:27PM +0500, Khadija Kamran wrote:
> 
> <snip>
> 
> > Hey Outreachy Mentors,
> > 
> > Kindly take a look at this patch and let me know if I should wait for
> > the response on this patch or submit another patch.
> 
> Less than 1 day later?
> 
> Please relax and always keep working on new things, don't let my
> response time be the gateway for you doing work, otherwise you are not
> going to get very much done at all.
> 
> You normally have to wait about 2 weeks to get a patch reviewed,
> sometimes I go much faster, sometimes slower.  Either way, it's
> uncertian...
> 
> thanks,
> 
> greg k-h

Okay understood.

Really sorry about this message.

Regards,
Khadija