From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: outreachy@lists.linux.dev,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: most: fix line ending with '('
Date: Wed, 22 Mar 2023 23:06:07 +0500 [thread overview]
Message-ID: <ZBtDj/sRJCiOhsRD@khadija-virtual-machine> (raw)
In-Reply-To: <8064a4ee-665b-417e-a1e2-7e7dd32ec1f0@kili.mountain>
On Wed, Mar 22, 2023 at 06:09:50PM +0300, Dan Carpenter wrote:
> On Wed, Mar 22, 2023 at 08:01:52PM +0500, Khadija Kamran wrote:
> > Splitting function header to multiple lines because of 80 characters per
> > line limit, results in ending the function call line with '('.
> > This leads to CHECK reported by checkpatch.pl
> >
> > Move the function parameters right after the '(' in the function call
> > line. Align the rest of the parameters to the opening parenthesis.
> >
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> >
> > Changes in v2:
> > - Changed the description
> >
>
> No one replied to the v1 of this patch so it's not clear which of the
> patches should be ignored.
>
Hey Dan!
I created a patch revision without any feedback. My bad. I thought the
description in the previous patch was misleading, so I wanted to change
it.
> Also you have a couple patches with the same subject and that's against
> the rules.
>
I am sorry about that. Kindly guide me here.
Both patches are for same driver i.e. staging/most, but for different
files. Would it be fine to add file names in the subject to
differentiate them?
Regards,
Khadija
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-03-22 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 15:01 [PATCH v2] staging: most: fix line ending with '(' Khadija Kamran
2023-03-22 15:09 ` Dan Carpenter
2023-03-22 18:06 ` Khadija Kamran [this message]
2023-03-23 4:48 ` Dan Carpenter
2023-03-23 12:06 ` Khadija Kamran
2023-03-22 15:12 ` Randy Dunlap
2023-03-23 4:14 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBtDj/sRJCiOhsRD@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox