From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from msg-4.mailo.com (msg-4.mailo.com [213.182.54.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C3DB17FC; Thu, 23 Mar 2023 05:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1679547980; bh=S+uqErVyJkzz4n1QVzjO1/HkYrFW3SD+hKC0FjAnjpQ=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=ba1lIJSY/bHFjwDpebtoqt9ECrtbQk2RTlB76H82Be6JT9wmTWJaiG3D6XU4N8HZZ uO5NOGuhWzHlb20bQf3qYlCHbX9n5d2j7r0KyPWqvVoA2En/MqnFVdAh3FuYzWV3P+ vseZtjAH1S5HZfLMgOYyRZlmr18FMS9OW8WTEyq4= Received: by b221-4.in.mailobj.net [192.168.90.24] with ESMTP via ip-20.mailobj.net [213.182.54.20] Thu, 23 Mar 2023 06:06:20 +0100 (CET) X-EA-Auth: x0hDPzU8TaWpIUg/LIBGQaCa74TJKUC8rvzPKoljQwtzLawHT5P7+rMyNcGYbGDsaUlz0C+kC9tkB9Oa3L284UXtdOJavh1a Date: Thu, 23 Mar 2023 10:35:59 +0530 From: Deepak R Varma To: Greg KH Cc: Julia Lawall , Alex Elder , Menna Mahmoud , outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: greybus: use inline function for macros Message-ID: References: <20230321183456.10385-1-eng.mennamahmoud.mm@gmail.com> <2e869677-2693-6419-ea25-f0cc2efcf3dd@ieee.org> <5efa6e6d-8573-31de-639a-d15b2e9deca0@ieee.org> <48674d8f-9753-780c-f37c-f83ea2855ae6@ieee.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 23, 2023 at 05:58:02AM +0100, Greg KH wrote: > Nice, that shows that it is the same both ways as the compiler version > you are using is smart enough > > Which compiler and version is this? Does it work the same for all of > the supported versions we have to support (i.e. really old gcc?) > > For the most part, sysfs files are not on any sort of "fast path" so a Hello, Is there a guideline/documentation on how to identify if a code is part of fast/slow path? > function call is fine, but as I mentioned before, sometimes we are > forced to move calls to container_of() to container_of_const() and that > can not be an inline function, but must remain a macro :( > > thanks, > > greg k-h >