From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3098F4A; Thu, 23 Mar 2023 12:06:10 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id x3so85375272edb.10; Thu, 23 Mar 2023 05:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679573168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0b1o3tcjjGCunc9G0qk/bdAz77AhUyucu+7MQcBhgJ8=; b=W1P0fQzSHbA9QOxmv9Zxb90U0FzlyXGoACDg5S+tEl0k6Hsi6iFLosZaunmuuJwCEG jhJr9PrPPXRD74/VJ435sEz6RBmx1KUTolZ56T0BPuYSMNsF+IqnyrioLdv3puxb43jg ZoTU/AuYqnrlN0BSy4/t7nSv8WhkwzqhfpDyBI3IbfrR/S85VDBwwB6gnXARM2SGdmmY NofjaSdrckReFjOux+XyHAA8Nm4TLXi/AQW0xyTx+/pZ6qYGIXA0EAcYGg/5jDVwCLzp 2+ZPzYlYVeLI9KIZxmykmLK727B9ylEW+tXEavRwymgzpwrBL94G79e6c8AfBTs6XtAE ZswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679573168; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0b1o3tcjjGCunc9G0qk/bdAz77AhUyucu+7MQcBhgJ8=; b=3pCT2dj/JE1+Gk05+z2SqA9/jdLU/7Mo2yJC2RsZXELG3OXtEnmWZW+dq37+IIgj8a BAJFrzJP4CdrlHL6nHghibxEbUAsJWzgmO6TGJ1KuLj9etMCXDK8k3hf+8e3RmP/pNRM Nk+rQfr0YnIRIaNqSWarDRVh4Ig+RaIfFFytNILJy+C3YtAAlzmGIUmVog6gIHkZPmcj B1yK6j7fjJslbuY8d1x49D9nnS+Vc5v071paTVZnqff/x7LgHTG+w+3+Af+7PX+L6tIP HjIgqsH+0wQ18oH/wVCLOie0xfe7O7agLVp/BXm9ZX4NN8a8ZXy3cDbpNuWiZw24kW9d VVCw== X-Gm-Message-State: AO0yUKVY8JSC3Kw8WU+x3p1Z73tbHDfVeiyVfNaiTjq+11N5da6fRJjr ZdZmxdoRoeHt7tI1FVyfGy8= X-Google-Smtp-Source: AK7set+QnsaEuAOcDuMjvIifg6pOFxEpoLtu5/trQDMYnKdIgx0Z7J6OFvtYho30UBFyUOirstM0JA== X-Received: by 2002:a05:6402:187:b0:4fb:5a36:1539 with SMTP id r7-20020a056402018700b004fb5a361539mr9268263edv.25.1679573168505; Thu, 23 Mar 2023 05:06:08 -0700 (PDT) Received: from khadija-virtual-machine ([39.41.14.14]) by smtp.gmail.com with ESMTPSA id l19-20020a170906079300b00932ed432475sm7398322ejc.124.2023.03.23.05.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:06:08 -0700 (PDT) Date: Thu, 23 Mar 2023 17:06:06 +0500 From: Khadija Kamran To: Dan Carpenter Cc: outreachy@lists.linux.dev, Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: most: fix line ending with '(' Message-ID: References: <8064a4ee-665b-417e-a1e2-7e7dd32ec1f0@kili.mountain> <6af8c3d2-de18-4149-a85b-8fb8235f6001@kili.mountain> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6af8c3d2-de18-4149-a85b-8fb8235f6001@kili.mountain> On Thu, Mar 23, 2023 at 07:48:11AM +0300, Dan Carpenter wrote: > On Wed, Mar 22, 2023 at 11:06:07PM +0500, Khadija Kamran wrote: > > On Wed, Mar 22, 2023 at 06:09:50PM +0300, Dan Carpenter wrote: > > > On Wed, Mar 22, 2023 at 08:01:52PM +0500, Khadija Kamran wrote: > > > > Splitting function header to multiple lines because of 80 characters per > > > > line limit, results in ending the function call line with '('. > > > > This leads to CHECK reported by checkpatch.pl > > > > > > > > Move the function parameters right after the '(' in the function call > > > > line. Align the rest of the parameters to the opening parenthesis. > > > > > > > > Signed-off-by: Khadija Kamran > > > > --- > > > > > > > > Changes in v2: > > > > - Changed the description > > > > > > > > > > No one replied to the v1 of this patch so it's not clear which of the > > > patches should be ignored. > > > > > > > Hey Dan! > > > > I created a patch revision without any feedback. My bad. I thought the > > description in the previous patch was misleading, so I wanted to change > > it. > > Yeah. But you have to reply to the other email. Otherwise how will we > know there was a response to it? > Hey Dan, I will keep that in mind next time. Sorry about this. Regards, Khadija > > > > > Also you have a couple patches with the same subject and that's against > > > the rules. > > > > > > > I am sorry about that. Kindly guide me here. > > Both patches are for same driver i.e. staging/most, but for different > > files. Would it be fine to add file names in the subject to > > differentiate them? > > > > I trust you. Figure out a way. ;) > > regards, > dan carpenter >