From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: fix line ending with '('
Date: Thu, 23 Mar 2023 20:17:59 +0500 [thread overview]
Message-ID: <ZBxtpyT8she++602@khadija-virtual-machine> (raw)
In-Reply-To: <ZBvbP8ugDFjSoVp/@kroah.com>
On Thu, Mar 23, 2023 at 05:53:19AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Mar 22, 2023 at 07:35:38PM +0500, Khadija Kamran wrote:
> > Splitting function header to multiple lines because of 80 characters per
> > line limit, results in ending the function call line with '('.
> > This leads to CHECK reported by checkpatch.pl
> >
> > Move the first parameter right after the '(' in the function call line.
> > Align the rest of the parameters to the opening parenthesis.
> >
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> > drivers/staging/most/dim2/hal.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
>
> You have 2 patches here with identical subject lines, yet they do
> different things :(
>
> I've dropped all of your pending patches now for the most driver as I'm
> totally confused. Please resend them all as a proper patch series with
> updated subject lines.
>
Hey Greg!
I took your message literally and sent a RESEND PATCH. I should've sent
a new version of the patch instead.
Would it be okay if I send patch revisions with changed subjects now?
My apologies for the inconvenience.
Regards,
Khadija
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-03-23 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:35 [PATCH] staging: most: fix line ending with '(' Khadija Kamran
2023-03-23 4:53 ` Greg Kroah-Hartman
2023-03-23 12:08 ` Khadija Kamran
2023-03-23 15:17 ` Khadija Kamran [this message]
2023-03-23 15:28 ` Greg Kroah-Hartman
2023-03-23 21:11 ` Khadija Kamran
-- strict thread matches above, loose matches on Subject: below --
2023-03-22 14:54 Khadija Kamran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBxtpyT8she++602@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).