[PATCH] staging: rtl8723bs: remove unused pHalData variable

linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

* [PATCH] staging: rtl8723bs: remove unused pHalData variable
@ 2023-03-26 12:23 Tom Rix
  2023-03-26 12:46 ` Nam Cao
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2023-03-26 12:23 UTC (permalink / raw)
  To: gregkh, nathan, ndesaulniers, artur.bujdoso, namcaov
  Cc: linux-staging, linux-kernel, llvm, Tom Rix

clang with W=1 reports
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
  'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
        struct hal_com_data *pHalData;
                             ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index e36f8c369a04..0cb2adcc1f78 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
 
 void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
 {
-	struct hal_com_data *pHalData;
-
-
-	pHalData = GET_HAL_DATA(padapter);
 }
 
 void hal_btcoex_SetPgAntNum(struct adapter *padapter, u8 antNum)
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable
  2023-03-26 12:23 [PATCH] staging: rtl8723bs: remove unused pHalData variable Tom Rix
@ 2023-03-26 12:46 ` Nam Cao
  2023-03-26 12:55   ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Nam Cao @ 2023-03-26 12:46 UTC (permalink / raw)
  To: Tom Rix
  Cc: gregkh, nathan, ndesaulniers, artur.bujdoso, linux-staging,
	linux-kernel, llvm

On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>   'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>         struct hal_com_data *pHalData;
>                              ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index e36f8c369a04..0cb2adcc1f78 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>  
>  void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>  {
> -	struct hal_com_data *pHalData;
> -
> -
> -	pHalData = GET_HAL_DATA(padapter);
>  }

If this function doesn't do anything, does it not make more sense to
just remove this function entirely?

Best regards,
Nam

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable
  2023-03-26 12:46 ` Nam Cao
@ 2023-03-26 12:55   ` Greg KH
  2023-03-26 13:13     ` Tom Rix
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2023-03-26 12:55 UTC (permalink / raw)
  To: Nam Cao
  Cc: Tom Rix, nathan, ndesaulniers, artur.bujdoso, linux-staging,
	linux-kernel, llvm

On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
> On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
> >   'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
> >         struct hal_com_data *pHalData;
> >                              ^
> > This variable is not used so remove it.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > index e36f8c369a04..0cb2adcc1f78 100644
> > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
> >  
> >  void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
> >  {
> > -	struct hal_com_data *pHalData;
> > -
> > -
> > -	pHalData = GET_HAL_DATA(padapter);
> >  }
> 
> If this function doesn't do anything, does it not make more sense to
> just remove this function entirely?

This function is already removed in linux-next, so it doesn't matter :)

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable
  2023-03-26 12:55   ` Greg KH
@ 2023-03-26 13:13     ` Tom Rix
  2023-03-26 13:20       ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2023-03-26 13:13 UTC (permalink / raw)
  To: Greg KH, Nam Cao
  Cc: nathan, ndesaulniers, artur.bujdoso, linux-staging, linux-kernel,
	llvm


On 3/26/23 5:55 AM, Greg KH wrote:
> On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
>> On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
>>> clang with W=1 reports
>>> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>>>    'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>>>          struct hal_com_data *pHalData;
>>>                               ^
>>> This variable is not used so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>>   drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> index e36f8c369a04..0cb2adcc1f78 100644
>>> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>>>   
>>>   void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>>>   {
>>> -	struct hal_com_data *pHalData;
>>> -
>>> -
>>> -	pHalData = GET_HAL_DATA(padapter);
>>>   }
>> If this function doesn't do anything, does it not make more sense to
>> just remove this function entirely?
> This function is already removed in linux-next, so it doesn't matter :)

My patch is against linux-next from tag next-20230324

Tom

>
> thanks,
>
> greg k-h
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: rtl8723bs: remove unused pHalData variable
  2023-03-26 13:13     ` Tom Rix
@ 2023-03-26 13:20       ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2023-03-26 13:20 UTC (permalink / raw)
  To: Tom Rix
  Cc: Nam Cao, nathan, ndesaulniers, artur.bujdoso, linux-staging,
	linux-kernel, llvm

On Sun, Mar 26, 2023 at 06:13:16AM -0700, Tom Rix wrote:
> 
> On 3/26/23 5:55 AM, Greg KH wrote:
> > On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
> > > On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> > > > clang with W=1 reports
> > > > drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
> > > >    'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
> > > >          struct hal_com_data *pHalData;
> > > >                               ^
> > > > This variable is not used so remove it.
> > > > 
> > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > ---
> > > >   drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
> > > >   1 file changed, 4 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > index e36f8c369a04..0cb2adcc1f78 100644
> > > > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
> > > >   void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
> > > >   {
> > > > -	struct hal_com_data *pHalData;
> > > > -
> > > > -
> > > > -	pHalData = GET_HAL_DATA(padapter);
> > > >   }
> > > If this function doesn't do anything, does it not make more sense to
> > > just remove this function entirely?
> > This function is already removed in linux-next, so it doesn't matter :)
> 
> My patch is against linux-next from tag next-20230324

Ah, ok, well it will be gone in the next one, as this is already gone in
my tree.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-26 13:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-26 12:23 [PATCH] staging: rtl8723bs: remove unused pHalData variable Tom Rix
2023-03-26 12:46 ` Nam Cao
2023-03-26 12:55   ` Greg KH
2023-03-26 13:13     ` Tom Rix
2023-03-26 13:20       ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).