* [PATCH] staging: rtl8192e: avoid CamelCase <RATRIndex>
@ 2023-04-25 0:48 John Grace
2023-04-26 22:54 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: John Grace @ 2023-04-25 0:48 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging
Linux kernel coding-style suggests to not use mixed-case names. Fix
checkpatch issue by changing the variable name from camel case to snake
case.
Signed-off-by: John Grace <johnmgrace1@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
drivers/staging/rtl8192e/rtllib_tx.c | 6 +++---
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index aed53fedeb61..c612e31d1a84 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1008,7 +1008,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
pdesc->PktSize = skb->len - sizeof(struct tx_fwinfo_8190pci);
pdesc->SecCAMID = 0;
- pdesc->RATid = cb_desc->RATRIndex;
+ pdesc->RATid = cb_desc->ratr_index;
pdesc->NoEnc = 1;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 27040d1e3230..b58a30d68f2f 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -466,7 +466,7 @@ static void _rtl92e_prepare_beacon(struct tasklet_struct *t)
tcb_desc = (struct cb_desc *)(pnewskb->cb + 8);
tcb_desc->queue_index = BEACON_QUEUE;
tcb_desc->data_rate = 2;
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_dis_rate_fallback = 1;
tcb_desc->tx_use_drv_assinged_rate = 1;
skb_push(pnewskb, priv->rtllib->tx_headroom);
@@ -1440,7 +1440,7 @@ static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
return 0;
}
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_dis_rate_fallback = 1;
tcb_desc->tx_use_drv_assinged_rate = 1;
tcb_desc->bTxEnableFwCalcDur = 1;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 6e665e866f1f..d5f5ea5615fc 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -139,7 +139,7 @@ struct cb_desc {
u8 rata_index;
u8 queue_index;
u16 txbuf_size;
- u8 RATRIndex;
+ u8 ratr_index;
u8 bAMSDU:1;
u8 bFromAggrQ:1;
u8 reserved6:6;
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index b9886e83a6dc..1ca77cdbafa3 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -219,7 +219,7 @@ inline void softmac_mgmt_xmit(struct sk_buff *skb, struct rtllib_device *ieee)
tcb_desc->queue_index = HIGH_QUEUE;
tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_dis_rate_fallback = 1;
tcb_desc->tx_use_drv_assinged_rate = 1;
if (single) {
@@ -297,7 +297,7 @@ softmac_ps_mgmt_xmit(struct sk_buff *skb,
tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_dis_rate_fallback = 1;
tcb_desc->tx_use_drv_assinged_rate = 1;
if (single) {
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 9ab8ee46ef66..54119fba8a57 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -486,7 +486,7 @@ static void rtllib_txrate_selectmode(struct rtllib_device *ieee,
!tcb_desc->tx_use_drv_assinged_rate) {
if (ieee->iw_mode == IW_MODE_INFRA ||
ieee->iw_mode == IW_MODE_ADHOC)
- tcb_desc->RATRIndex = 0;
+ tcb_desc->ratr_index = 0;
}
}
@@ -892,7 +892,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
tcb_desc->tx_dis_rate_fallback = 1;
}
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_use_drv_assinged_rate = 1;
} else {
if (is_multicast_ether_addr(header.addr1))
@@ -916,7 +916,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
tcb_desc->tx_dis_rate_fallback = 1;
}
- tcb_desc->RATRIndex = 7;
+ tcb_desc->ratr_index = 7;
tcb_desc->tx_use_drv_assinged_rate = 1;
tcb_desc->bdhcp = 1;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: avoid CamelCase <RATRIndex>
2023-04-25 0:48 [PATCH] staging: rtl8192e: avoid CamelCase <RATRIndex> John Grace
@ 2023-04-26 22:54 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2023-04-26 22:54 UTC (permalink / raw)
To: John Grace, gregkh; +Cc: linux-staging
On 4/25/23 02:48, John Grace wrote:
> Linux kernel coding-style suggests to not use mixed-case names. Fix
> checkpatch issue by changing the variable name from camel case to snake
> case.
>
> Signed-off-by: John Grace <johnmgrace1@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
> drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++--
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++--
> drivers/staging/rtl8192e/rtllib_tx.c | 6 +++---
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index aed53fedeb61..c612e31d1a84 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -1008,7 +1008,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
> pdesc->PktSize = skb->len - sizeof(struct tx_fwinfo_8190pci);
>
> pdesc->SecCAMID = 0;
> - pdesc->RATid = cb_desc->RATRIndex;
> + pdesc->RATid = cb_desc->ratr_index;
>
>
> pdesc->NoEnc = 1;
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> index 27040d1e3230..b58a30d68f2f 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
> @@ -466,7 +466,7 @@ static void _rtl92e_prepare_beacon(struct tasklet_struct *t)
> tcb_desc = (struct cb_desc *)(pnewskb->cb + 8);
> tcb_desc->queue_index = BEACON_QUEUE;
> tcb_desc->data_rate = 2;
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_dis_rate_fallback = 1;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> skb_push(pnewskb, priv->rtllib->tx_headroom);
> @@ -1440,7 +1440,7 @@ static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
> return 0;
> }
>
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_dis_rate_fallback = 1;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> tcb_desc->bTxEnableFwCalcDur = 1;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 6e665e866f1f..d5f5ea5615fc 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -139,7 +139,7 @@ struct cb_desc {
> u8 rata_index;
> u8 queue_index;
> u16 txbuf_size;
> - u8 RATRIndex;
> + u8 ratr_index;
> u8 bAMSDU:1;
> u8 bFromAggrQ:1;
> u8 reserved6:6;
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index b9886e83a6dc..1ca77cdbafa3 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -219,7 +219,7 @@ inline void softmac_mgmt_xmit(struct sk_buff *skb, struct rtllib_device *ieee)
> tcb_desc->queue_index = HIGH_QUEUE;
>
> tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_dis_rate_fallback = 1;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> if (single) {
> @@ -297,7 +297,7 @@ softmac_ps_mgmt_xmit(struct sk_buff *skb,
>
>
> tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_dis_rate_fallback = 1;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> if (single) {
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index 9ab8ee46ef66..54119fba8a57 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -486,7 +486,7 @@ static void rtllib_txrate_selectmode(struct rtllib_device *ieee,
> !tcb_desc->tx_use_drv_assinged_rate) {
> if (ieee->iw_mode == IW_MODE_INFRA ||
> ieee->iw_mode == IW_MODE_ADHOC)
> - tcb_desc->RATRIndex = 0;
> + tcb_desc->ratr_index = 0;
> }
> }
>
> @@ -892,7 +892,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> tcb_desc->tx_dis_rate_fallback = 1;
> }
>
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> } else {
> if (is_multicast_ether_addr(header.addr1))
> @@ -916,7 +916,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> tcb_desc->tx_dis_rate_fallback = 1;
> }
>
> - tcb_desc->RATRIndex = 7;
> + tcb_desc->ratr_index = 7;
> tcb_desc->tx_use_drv_assinged_rate = 1;
> tcb_desc->bdhcp = 1;
> }
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-26 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-25 0:48 [PATCH] staging: rtl8192e: avoid CamelCase <RATRIndex> John Grace
2023-04-26 22:54 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox