From: wangjinchao <wangjinchao@xfusion.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"outreachy@lists.linux.dev" <outreachy@lists.linux.dev>
Cc: xulei <stone.xulei@xfusion.com>
Subject: [PATCH] staging: rtl8192u: Fix assignment in if condition
Date: Tue, 4 Jul 2023 12:15:57 +0000 [thread overview]
Message-ID: <ZKP/01ECsgmdBFf2@fedora> (raw)
I just participated in Outreachy of KernelNewbies and fixed one
'ERROR: do not use assignment in if condition' issue reported by
checkpatch.pl on drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c.
Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index ca09367005e1..52ff9e62ec08 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -1121,8 +1121,9 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
/* skb: hdr + (possibly fragmented, possibly encrypted) payload */
+ keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt);
if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) &&
- (keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) {
+ keyidx < 0) {
netdev_dbg(ieee->dev, "decrypt frame error\n");
goto rx_dropped;
}
--
2.40.0
next reply other threads:[~2023-07-04 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 12:15 wangjinchao [this message]
2023-07-04 12:31 ` [PATCH] staging: rtl8192u: Fix assignment in if condition Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKP/01ECsgmdBFf2@fedora \
--to=wangjinchao@xfusion.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=stone.xulei@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox