From: Tree Davies <tdavies@darkphysics.net>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Rename variable bCurrentHTSupport
Date: Tue, 18 Jul 2023 20:32:04 -0700 [thread overview]
Message-ID: <ZLdZNNs/NlbWAFCP@basil> (raw)
In-Reply-To: <95e0287d-3211-3c0d-7a52-740acdb75f45@gmail.com>
On Tue, Jul 18, 2023 at 09:56:24PM +0200, Philipp Hortmann wrote:
> On 7/15/23 22:14, Tree Davies wrote:
> > Philipp,
> >
> > I think I understand what I did wrong. Each of these original patches were
> > created/based from the same commit hash. So it makes sense that only the
> > first one applied would apply cleanly and the others would fail.
> >
> > My apologies,
> > Tree
>
> Hi Tree,
>
> you could work this way if you ensure that each patch does not modify code
> (and some lines above and below) a previous patch modified. But it is not a
> good way to do so. Existing tools assume that you create your commits onto
> each other and then make patches out of them.
>
> Another issue right now is that approximately 18 patches send in and are
> possibly applied (for rtl8192e). Your patches need to fit onto those
> patches. Otherwise they cannot be applied and will be rejected.
>
> Typically Greg applies all patches once a week. But it seems that he has a
> bunch of other more urgent tasks. So you need to focus on other kernel
> related task like educate yourself or prepare patches without sending them
> in.
>
> Thanks for your support.
>
> Bye Philipp
>
Thnaks Philipp,
No worries, I'm patient, and happy to help any way I can.
I have hardware coming in the mail this week! I already have
3 mPCIe rtl8192e devices, but I am waiting on the PCIe adapter card for
my test machine.
I'm stoked. :)
Tree
next prev parent reply other threads:[~2023-07-19 3:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 1:59 [PATCH] staging: rtl8192e: Rename variable bCurrentHTSupport Tree Davies
2023-07-06 20:48 ` Philipp Hortmann
2023-07-07 2:56 ` Tree Davies
2023-07-15 20:14 ` Tree Davies
2023-07-18 19:56 ` Philipp Hortmann
2023-07-19 3:32 ` Tree Davies [this message]
2023-07-20 19:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLdZNNs/NlbWAFCP@basil \
--to=tdavies@darkphysics.net \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).