From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B7B2156FA; Thu, 20 Jul 2023 06:48:17 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2b8392076c9so5699091fa.1; Wed, 19 Jul 2023 23:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689835695; x=1692427695; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1FkW5AFugHIm4cfLHhBTJhPmVsKSDHP6cvkrfUVdciI=; b=AzOk4HbUt9ZK+jgh2do1VmTnHs4dXgElnWxrvk/ChEHWWQTAZ9Vx8z7XNmRbDqPxZ3 pze3ozYAKUdVg1bDR93gP5GhKEdWWBQ0Z3hpvKSTR3aWKlVmMyKb7oVA0LynQyTcgKv2 D6nSHWT0sTsM7wGrLweBRaxKnv4ScXH6R7hljPkQgdoR9wDPheqU4d3pdCm1+3XDKlWu aJeDJRsVcVA+LxTuN/Lh17Y4eVWY7TL9dsBZ5PDZgdTD3S9dyqQ48/KqD62XG+MERd3j v9OutwMGBMZU+qjEDSgxHB5ePtRice9fyfrHWxUYpDn/Ip6PxSF/NyTWH7Duq9PsJPVr i08A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689835695; x=1692427695; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1FkW5AFugHIm4cfLHhBTJhPmVsKSDHP6cvkrfUVdciI=; b=hq22l1euOaWp9UGj/W36jEkSS79QvuSvFXCpMPTkQDyj9fFkaH1UFYwMLO5Fu+B/ua Czficba45XDy0pXIz5dYcibqX/bpxQRV6+hFSrK4UYcGrEGrjkjpFR1UPSAlMMtqokZg 4jgamQLPVOkDQ8Gc1QGo5TKJrTqFFm+HnlUwyqDYHwATrA++KK/qX5Zsuaz+79kaqMiq cP4iRW1nZ69GhNgSe3Zs5XXXdMNt/q7Ua7PvuGQyukA3fE+pFUEBwTbM5+0ul81L4Gwh Jsf6bXl499fNuLebBNV6G71y7XW9qnJU3NOu+kZorw1y52YburUkLbGTW+6y40lxc87X aHiQ== X-Gm-Message-State: ABy/qLbaJXBa80B9Osb9GnSA5Tk2atWdCgaoD6RYFJAfux3sVfVsFMOx LU185Jqp9idOst2D9Imeiak= X-Google-Smtp-Source: APBJJlGrST9hDWvezaAooUi3+dItEEwvvxovRyenIedKgx3brcqw6G9KmcKqHf4GtKi+d6VaNG3D9g== X-Received: by 2002:a2e:9901:0:b0:2b6:df6b:84c0 with SMTP id v1-20020a2e9901000000b002b6df6b84c0mr1063490lji.25.1689835694948; Wed, 19 Jul 2023 23:48:14 -0700 (PDT) Received: from orome (p200300e41f1bd600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1b:d600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id u9-20020a05600c210900b003fbcdba1a52sm3162159wml.3.2023.07.19.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 23:48:14 -0700 (PDT) Date: Thu, 20 Jul 2023 08:48:11 +0200 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Florian Fainelli , Ray Jui , Scott Branden , Benson Leung , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Michael Walle , Johan Hovold , Alex Elder , Greg Kroah-Hartman , linux-pwm@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, Broadcom internal kernel review list , Guenter Roeck , chrome-platform@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Message-ID: References: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qz371AQYCl6mZiXj" Content-Disposition: inline In-Reply-To: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/2.2.10 (2023-03-25) --qz371AQYCl6mZiXj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-K=C3=B6nig wrote: > while working on an extension for the pwm framework, I noticed that some > drivers and even the core only nearly consistently named all variables > and struct members holding a pointer to a struct pwm_chip "chip": >=20 > $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc= 1 | sort | uniq -c | sort -n > 1 struct pwm_chip *pwm > 1 struct pwm_chip pwm > 1 struct pwm_chip pwm_chip > 2 struct pwm_chip *_chip > 4 struct pwm_chip *c > 8 struct pwm_chip *pc > 57 struct pwm_chip chip > 358 struct pwm_chip *chip >=20 > With this series applied these are all called "chip" with one exception: > The led driver drivers/leds/rgb/leds-qcom-lpg.c uses "pwm". Maybe > "pwmchip" would be a better name, but I'm not sure that using "chip" was > an improvement there as this isn't a pure pwm driver. I'm not touching > that one. >=20 > The first offenders I found were the core and the atmel-hlcdc driver. > After I found these I optimistically assumed these were the only ones > with the unusual names and send patches for these out individually > before checking systematically. >=20 > The atmel-hlcdc patch is included here unchanged, the core patch now > also adapted the declaration of the changed functions in . > I marked these two as "superseded" in patchwork already. >=20 > All patches in this series are pairwise independent of each other. I > don't know if the staging patch should better go in via the greybus tree > or via pwm. Both is possible without needing coordination. >=20 > Best regards > Uwe >=20 >=20 > Uwe Kleine-K=C3=B6nig (10): > pwm: Use a consistent name for pwm_chip pointers in the core > pwm: atmel-hlcdc: Use consistent variable naming > pwm: bcm-kona: Consistenly name pwm_chip variables "chip" > pwm: crc: Consistenly name pwm_chip variables "chip" > pwm: cros-ec: Consistenly name pwm_chip variables "chip" > pwm: lp3943: Consistenly name pwm_chip variables "chip" > pwm: rockchip: Consistenly name pwm_chip variables "chip" > pwm: sifive: Consistenly name pwm_chip variables "chip" > pwm: sl28cpld: Consistenly name pwm_chip variables "chip" > staging: greybus: pwm: Consistenly name pwm_chip variables "chip" This would've been much easier if it had been a single patch. Now I have to either make you redo the whole series because you've misspelled PWM or I have to go and update it myself in most of the above patches. Hint: I'll do the latter. There is really no reason to split this up into this many patches for such a trivial change. Thierry --qz371AQYCl6mZiXj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS42KkACgkQ3SOs138+ s6Hrcw//bT6JKDpq1cRgHldmJl93Sju6hsTYMrblCoA1pa6rfV9XZX1D8K1gZUOl K+6a1mUlkjv1KR7pIvUU7PG47vE66IXBNwAZYLfXYKmrCBiWjF+mT6Azm2rwPguM 02gt5Fmv0Xp0CZ3yc2N4CHhiC+MsyhkliuK/dMfejMaPSQjs3F+yMPo4FUON+CJx oy+okmnI6VYMtpAX3qDvJ7lrqgmw6CMwkxrYPaCtnzRGYLxOyixhoYy3KzgWS8BO Aukgm24XROAuq58cCp9EjxYtMWR7jmJdaqY3DVaE4XaAuklI5/s0QfTSachQbTOu Fv/+/1K4cZjTEhg+qSfSq5xIkmDqDDcHFw5Kobcv9xjXegeFLnrTl541jiMLkgcs U4zY0OGXm2OZrhqQRj4WmJd8YAkqZbLTquSQb2AtjNyITFKlgQg28Ct6gr5Go9eb Te+RAcoQkDuIs0qEJe+07qkCEngilTGdXf59kymAsdDzWqM+7qEDOMYnmWzl06KJ qQFbms1FtSzldFO+upYAYMynS4K2Ni+EY6KbocmUwvs9vYw6FC8pmyfAXvFdGD8D MXljW6kvcoycIOPlwME1H+b3EourwQhI/wnjLyYmB8Z921+NJZ9D3Bj5ey16YzEp ZGqr2I+AgbDzS0yQAM/utgHE9jOZy6KOnQGeWvXYOeUSVDlrobA= =iJ4i -----END PGP SIGNATURE----- --qz371AQYCl6mZiXj--