* [PATCH v3 1/5] Staging: rtl8192e: Rename function ActivateBAEntry
2023-07-28 5:47 [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
@ 2023-07-28 5:47 ` Tree Davies
2023-07-28 5:47 ` [PATCH v3 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Tree Davies
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-07-28 5:47 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan, error27
Cc: linux-staging, linux-kernel, Tree Davies
Rename function ActivateBAEntry to activate_ba_entry in order to Fix
checkpatch warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
v2: Sent to mailing list via git send-email, patches are the same.
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index acc19514bca6..965ffa8b78c2 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -10,7 +10,7 @@
#include "rtllib.h"
#include "rtl819x_BA.h"
-static void ActivateBAEntry(struct ba_record *pBA, u16 Time)
+static void activate_ba_entry(struct ba_record *pBA, u16 Time)
{
pBA->b_valid = true;
if (Time != 0)
@@ -282,7 +282,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
else
pBA->ba_param_set.field.buffer_size = 32;
- ActivateBAEntry(pBA, 0);
+ activate_ba_entry(pBA, 0);
rtllib_send_ADDBARsp(ieee, dst, pBA, ADDBA_STATUS_SUCCESS);
return 0;
@@ -379,7 +379,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl;
pAdmittedBA->ba_param_set = *pBaParamSet;
DeActivateBAEntry(ieee, pAdmittedBA);
- ActivateBAEntry(pAdmittedBA, *pBaTimeoutVal);
+ activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
} else {
pTS->bAddBaReqDelayed = true;
pTS->bDisable_AddBa = true;
@@ -479,7 +479,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS,
pBA->ba_timeout_value = 0;
pBA->ba_start_seq_ctrl.field.seq_num = (pTS->TxCurSeq + 3) % 4096;
- ActivateBAEntry(pBA, BA_SETUP_TIMEOUT);
+ activate_ba_entry(pBA, BA_SETUP_TIMEOUT);
rtllib_send_ADDBAReq(ieee, pTS->TsCommonInfo.Addr, pBA);
}
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry
2023-07-28 5:47 [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
2023-07-28 5:47 ` [PATCH v3 1/5] Staging: rtl8192e: Rename function ActivateBAEntry Tree Davies
@ 2023-07-28 5:47 ` Tree Davies
2023-07-28 5:47 ` [PATCH v3 3/5] Staging: rtl8192e: Rename function TxTsDeleteBA Tree Davies
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-07-28 5:47 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan, error27
Cc: linux-staging, linux-kernel, Tree Davies
Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix
checkpatch warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
v2: Sent to mailing list via git send-email, patches are the same.
drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 965ffa8b78c2..50362bbbc8dd 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -17,7 +17,7 @@ static void activate_ba_entry(struct ba_record *pBA, u16 Time)
mod_timer(&pBA->timer, jiffies + msecs_to_jiffies(Time));
}
-static void DeActivateBAEntry(struct rtllib_device *ieee, struct ba_record *pBA)
+static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pBA)
{
pBA->b_valid = false;
del_timer_sync(&pBA->timer);
@@ -30,12 +30,12 @@ static u8 TxTsDeleteBA(struct rtllib_device *ieee, struct tx_ts_record *pTxTs)
u8 bSendDELBA = false;
if (pPendingBa->b_valid) {
- DeActivateBAEntry(ieee, pPendingBa);
+ deactivate_ba_entry(ieee, pPendingBa);
bSendDELBA = true;
}
if (pAdmittedBa->b_valid) {
- DeActivateBAEntry(ieee, pAdmittedBa);
+ deactivate_ba_entry(ieee, pAdmittedBa);
bSendDELBA = true;
}
return bSendDELBA;
@@ -47,7 +47,7 @@ static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
u8 bSendDELBA = false;
if (pBa->b_valid) {
- DeActivateBAEntry(ieee, pBa);
+ deactivate_ba_entry(ieee, pBa);
bSendDELBA = true;
}
@@ -270,7 +270,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
rtllib_FlushRxTsPendingPkts(ieee, pTS);
- DeActivateBAEntry(ieee, pBA);
+ deactivate_ba_entry(ieee, pBA);
pBA->dialog_token = *pDialogToken;
pBA->ba_param_set = *pBaParamSet;
pBA->ba_timeout_value = *pBaTimeoutVal;
@@ -363,13 +363,13 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
netdev_dbg(ieee->dev,
"%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n",
__func__, *pStatusCode);
- DeActivateBAEntry(ieee, pPendingBA);
+ deactivate_ba_entry(ieee, pPendingBA);
}
if (*pStatusCode == ADDBA_STATUS_SUCCESS) {
if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
pTS->bAddBaReqDelayed = true;
- DeActivateBAEntry(ieee, pAdmittedBA);
+ deactivate_ba_entry(ieee, pAdmittedBA);
ReasonCode = DELBA_REASON_END_BA;
goto OnADDBARsp_Reject;
}
@@ -378,7 +378,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb)
pAdmittedBA->ba_timeout_value = *pBaTimeoutVal;
pAdmittedBA->ba_start_seq_ctrl = pPendingBA->ba_start_seq_ctrl;
pAdmittedBA->ba_param_set = *pBaParamSet;
- DeActivateBAEntry(ieee, pAdmittedBA);
+ deactivate_ba_entry(ieee, pAdmittedBA);
activate_ba_entry(pAdmittedBA, *pBaTimeoutVal);
} else {
pTS->bAddBaReqDelayed = true;
@@ -469,7 +469,7 @@ void TsInitAddBA(struct rtllib_device *ieee, struct tx_ts_record *pTS,
if (pBA->b_valid && !bOverwritePending)
return;
- DeActivateBAEntry(ieee, pBA);
+ deactivate_ba_entry(ieee, pBA);
pBA->dialog_token++;
pBA->ba_param_set.field.amsdu_support = 0;
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 3/5] Staging: rtl8192e: Rename function TxTsDeleteBA
2023-07-28 5:47 [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
2023-07-28 5:47 ` [PATCH v3 1/5] Staging: rtl8192e: Rename function ActivateBAEntry Tree Davies
2023-07-28 5:47 ` [PATCH v3 2/5] Staging: rtl8192e: Rename function DeActivateBAEntry Tree Davies
@ 2023-07-28 5:47 ` Tree Davies
2023-07-28 5:47 ` [PATCH v3 4/5] Staging: rtl8192e: Rename function RxTsDeleteBA Tree Davies
2023-07-28 6:16 ` [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Philipp Hortmann
4 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-07-28 5:47 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan, error27
Cc: linux-staging, linux-kernel, Tree Davies
Rename function TxTsDeleteBA to tx_ts_delete_ba in order to Fix checkpatch
warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
v2: Sent to mailing list via git send-email, patches are the same.
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 50362bbbc8dd..6538343ea44d 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -23,7 +23,7 @@ static void deactivate_ba_entry(struct rtllib_device *ieee, struct ba_record *pB
del_timer_sync(&pBA->timer);
}
-static u8 TxTsDeleteBA(struct rtllib_device *ieee, struct tx_ts_record *pTxTs)
+static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs)
{
struct ba_record *pAdmittedBa = &pTxTs->TxAdmittedBARecord;
struct ba_record *pPendingBa = &pTxTs->TxPendingBARecord;
@@ -456,7 +456,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
pTxTs->bAddBaReqInProgress = false;
pTxTs->bAddBaReqDelayed = false;
del_timer_sync(&pTxTs->TsAddBaTimer);
- TxTsDeleteBA(ieee, pTxTs);
+ tx_ts_delete_ba(ieee, pTxTs);
}
return 0;
}
@@ -492,7 +492,7 @@ void TsInitDelBA(struct rtllib_device *ieee,
struct tx_ts_record *pTxTs =
(struct tx_ts_record *)pTsCommonInfo;
- if (TxTsDeleteBA(ieee, pTxTs))
+ if (tx_ts_delete_ba(ieee, pTxTs))
rtllib_send_DELBA(ieee, pTsCommonInfo->Addr,
(pTxTs->TxAdmittedBARecord.b_valid) ?
(&pTxTs->TxAdmittedBARecord) :
@@ -524,7 +524,7 @@ void TxBaInactTimeout(struct timer_list *t)
TxAdmittedBARecord.timer);
struct rtllib_device *ieee = container_of(pTxTs, struct rtllib_device,
TxTsRecord[pTxTs->num]);
- TxTsDeleteBA(ieee, pTxTs);
+ tx_ts_delete_ba(ieee, pTxTs);
rtllib_send_DELBA(ieee, pTxTs->TsCommonInfo.Addr,
&pTxTs->TxAdmittedBARecord, TX_DIR,
DELBA_REASON_TIMEOUT);
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 4/5] Staging: rtl8192e: Rename function RxTsDeleteBA
2023-07-28 5:47 [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
` (2 preceding siblings ...)
2023-07-28 5:47 ` [PATCH v3 3/5] Staging: rtl8192e: Rename function TxTsDeleteBA Tree Davies
@ 2023-07-28 5:47 ` Tree Davies
2023-07-28 6:16 ` [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Philipp Hortmann
4 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-07-28 5:47 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann, anjan, error27
Cc: linux-staging, linux-kernel, Tree Davies
Rename function RxTsDeleteBA to rx_ts_delete_ba in order to Fix checkpatch
warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
v2: Sent to mailing list via git send-email, patches are the same.
drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 6538343ea44d..9662d75257ce 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -41,7 +41,7 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
return bSendDELBA;
}
-static u8 RxTsDeleteBA(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
+static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
{
struct ba_record *pBa = &pRxTs->rx_admitted_ba_record;
u8 bSendDELBA = false;
@@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
return -1;
}
- RxTsDeleteBA(ieee, pRxTs);
+ rx_ts_delete_ba(ieee, pRxTs);
} else {
struct tx_ts_record *pTxTs;
@@ -501,7 +501,7 @@ void TsInitDelBA(struct rtllib_device *ieee,
} else if (TxRxSelect == RX_DIR) {
struct rx_ts_record *pRxTs =
(struct rx_ts_record *)pTsCommonInfo;
- if (RxTsDeleteBA(ieee, pRxTs))
+ if (rx_ts_delete_ba(ieee, pRxTs))
rtllib_send_DELBA(ieee, pTsCommonInfo->Addr,
&pRxTs->rx_admitted_ba_record,
TxRxSelect, DELBA_REASON_END_BA);
@@ -537,7 +537,7 @@ void RxBaInactTimeout(struct timer_list *t)
struct rtllib_device *ieee = container_of(pRxTs, struct rtllib_device,
RxTsRecord[pRxTs->num]);
- RxTsDeleteBA(ieee, pRxTs);
+ rx_ts_delete_ba(ieee, pRxTs);
rtllib_send_DELBA(ieee, pRxTs->ts_common_info.Addr,
&pRxTs->rx_admitted_ba_record, RX_DIR,
DELBA_REASON_TIMEOUT);
--
2.41.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1
2023-07-28 5:47 [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Tree Davies
` (3 preceding siblings ...)
2023-07-28 5:47 ` [PATCH v3 4/5] Staging: rtl8192e: Rename function RxTsDeleteBA Tree Davies
@ 2023-07-28 6:16 ` Philipp Hortmann
2023-07-28 6:27 ` Tree Davies
4 siblings, 1 reply; 9+ messages in thread
From: Philipp Hortmann @ 2023-07-28 6:16 UTC (permalink / raw)
To: Tree Davies, gregkh, anjan, error27; +Cc: linux-staging, linux-kernel
On 7/28/23 07:47, Tree Davies wrote:
> Rename functions to fix checkpatch warning: Avoid CamelCase
>
>
> Changelist:
> v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> v2: Sent to mailing list via git send-email, patches are the same.
>
> Tree Davies (5):
> Staging: rtl8192e: Rename function ActivateBAEntry
> Staging: rtl8192e: Rename function DeActivateBAEntry
> Staging: rtl8192e: Rename function TxTsDeleteBA
> Staging: rtl8192e: Rename function RxTsDeleteBA
> Staging: rtl8192e: Rename function ResetBaEntry
>
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 ++--
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> 3 files changed, 26 insertions(+), 26 deletions(-)
>
Hi Tree,
those patches have been accepted and cannot be applied again.
commit c928e84ce577262da288c0178c8c77620ba8b430 (HEAD ->
staging-testing, origin/staging-testing)
Author: Tree Davies <tdavies@darkphysics.net>
Date: Wed Jul 26 23:19:47 2023 -0700
Staging: rtl8192e: Rename function RxTsDeleteBA
Rename function RxTsDeleteBA to rx_ts_delete_ba in order to Fix
checkpatch
warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link:
https://lore.kernel.org/r/20230727061948.579480-5-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit 7b31905582358d566332182653a4e5552dba1574
Author: Tree Davies <tdavies@darkphysics.net>
Date: Wed Jul 26 23:19:46 2023 -0700
Staging: rtl8192e: Rename function TxTsDeleteBA
Rename function TxTsDeleteBA to tx_ts_delete_ba in order to Fix
checkpatch
warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link:
https://lore.kernel.org/r/20230727061948.579480-4-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit 8dd56eaa9450fb19f6bcc73956b3b1477331d28b
Author: Tree Davies <tdavies@darkphysics.net>
Date: Wed Jul 26 23:19:45 2023 -0700
Staging: rtl8192e: Rename function DeActivateBAEntry
Rename function DeActivateBAEntry to deactivate_ba_entry in order
to Fix
checkpatch warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link:
https://lore.kernel.org/r/20230727061948.579480-3-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit ca77687ae3f6d65fb26a0e1f93b54753af3581fc
Author: Tree Davies <tdavies@darkphysics.net>
Date: Wed Jul 26 23:19:44 2023 -0700
Staging: rtl8192e: Rename function ActivateBAEntry
Rename function ActivateBAEntry to activate_ba_entry in order to Fix
checkpatch warning: Avoid CamelCase
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
Link:
https://lore.kernel.org/r/20230727061948.579480-2-tdavies@darkphysics.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bye Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1
2023-07-28 6:16 ` [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1 Philipp Hortmann
@ 2023-07-28 6:27 ` Tree Davies
2023-07-28 6:49 ` Dan Carpenter
0 siblings, 1 reply; 9+ messages in thread
From: Tree Davies @ 2023-07-28 6:27 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: gregkh, anjan, error27, linux-staging, linux-kernel
On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> On 7/28/23 07:47, Tree Davies wrote:
> > Rename functions to fix checkpatch warning: Avoid CamelCase
> >
> >
> > Changelist:
> > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > v2: Sent to mailing list via git send-email, patches are the same.
> >
> > Tree Davies (5):
> > Staging: rtl8192e: Rename function ActivateBAEntry
> > Staging: rtl8192e: Rename function DeActivateBAEntry
> > Staging: rtl8192e: Rename function TxTsDeleteBA
> > Staging: rtl8192e: Rename function RxTsDeleteBA
> > Staging: rtl8192e: Rename function ResetBaEntry
> >
> > drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> > drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 ++--
> > drivers/staging/rtl8192e/rtllib.h | 2 +-
> > 3 files changed, 26 insertions(+), 26 deletions(-)
> >
> Hi Tree,
>
> those patches have been accepted and cannot be applied again.
>
Hi Philipp,
Right, patch #5 was not accepted though. Grep asked to fix it up.
I thought that because it was part of that series I was supposed to
resend as new version.
Tree
> commit c928e84ce577262da288c0178c8c77620ba8b430 (HEAD -> staging-testing,
> origin/staging-testing)
> Author: Tree Davies <tdavies@darkphysics.net>
> Date: Wed Jul 26 23:19:47 2023 -0700
>
> Staging: rtl8192e: Rename function RxTsDeleteBA
>
> Rename function RxTsDeleteBA to rx_ts_delete_ba in order to Fix
> checkpatch
> warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> Link:
> https://lore.kernel.org/r/20230727061948.579480-5-tdavies@darkphysics.net
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> commit 7b31905582358d566332182653a4e5552dba1574
> Author: Tree Davies <tdavies@darkphysics.net>
> Date: Wed Jul 26 23:19:46 2023 -0700
>
> Staging: rtl8192e: Rename function TxTsDeleteBA
>
> Rename function TxTsDeleteBA to tx_ts_delete_ba in order to Fix
> checkpatch
> warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> Link:
> https://lore.kernel.org/r/20230727061948.579480-4-tdavies@darkphysics.net
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> commit 8dd56eaa9450fb19f6bcc73956b3b1477331d28b
> Author: Tree Davies <tdavies@darkphysics.net>
> Date: Wed Jul 26 23:19:45 2023 -0700
>
> Staging: rtl8192e: Rename function DeActivateBAEntry
>
> Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix
> checkpatch warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> Link:
> https://lore.kernel.org/r/20230727061948.579480-3-tdavies@darkphysics.net
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> commit ca77687ae3f6d65fb26a0e1f93b54753af3581fc
> Author: Tree Davies <tdavies@darkphysics.net>
> Date: Wed Jul 26 23:19:44 2023 -0700
>
> Staging: rtl8192e: Rename function ActivateBAEntry
>
> Rename function ActivateBAEntry to activate_ba_entry in order to Fix
> checkpatch warning: Avoid CamelCase
>
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> Link:
> https://lore.kernel.org/r/20230727061948.579480-2-tdavies@darkphysics.net
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> Bye Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1
2023-07-28 6:27 ` Tree Davies
@ 2023-07-28 6:49 ` Dan Carpenter
2023-07-28 7:08 ` Tree Davies
0 siblings, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2023-07-28 6:49 UTC (permalink / raw)
To: Tree Davies
Cc: Philipp Hortmann, gregkh, anjan, error27, linux-staging,
linux-kernel
On Thu, Jul 27, 2023 at 11:27:37PM -0700, Tree Davies wrote:
> On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> > On 7/28/23 07:47, Tree Davies wrote:
> > > Rename functions to fix checkpatch warning: Avoid CamelCase
> > >
> > >
> > > Changelist:
> > > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > > v2: Sent to mailing list via git send-email, patches are the same.
> > >
> > > Tree Davies (5):
> > > Staging: rtl8192e: Rename function ActivateBAEntry
> > > Staging: rtl8192e: Rename function DeActivateBAEntry
> > > Staging: rtl8192e: Rename function TxTsDeleteBA
> > > Staging: rtl8192e: Rename function RxTsDeleteBA
> > > Staging: rtl8192e: Rename function ResetBaEntry
> > >
> > > drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> > > drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 ++--
> > > drivers/staging/rtl8192e/rtllib.h | 2 +-
> > > 3 files changed, 26 insertions(+), 26 deletions(-)
> > >
> > Hi Tree,
> >
> > those patches have been accepted and cannot be applied again.
> >
>
> Hi Philipp,
>
> Right, patch #5 was not accepted though. Grep asked to fix it up.
> I thought that because it was part of that series I was supposed to
> resend as new version.
But now you understand what to do, right? Pull the latest code and do
all your work on top of that. Don't resend the stuff which was applied.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/5] Staging: rtl8192e: Function name cleanup series 1
2023-07-28 6:49 ` Dan Carpenter
@ 2023-07-28 7:08 ` Tree Davies
0 siblings, 0 replies; 9+ messages in thread
From: Tree Davies @ 2023-07-28 7:08 UTC (permalink / raw)
To: Dan Carpenter
Cc: Philipp Hortmann, gregkh, anjan, error27, linux-staging,
linux-kernel
On Fri, Jul 28, 2023 at 09:49:26AM +0300, Dan Carpenter wrote:
> On Thu, Jul 27, 2023 at 11:27:37PM -0700, Tree Davies wrote:
> > On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> > > On 7/28/23 07:47, Tree Davies wrote:
> > > > Rename functions to fix checkpatch warning: Avoid CamelCase
> > > >
> > > >
> > > > Changelist:
> > > > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > > > v2: Sent to mailing list via git send-email, patches are the same.
> > > >
> > > > Tree Davies (5):
> > > > Staging: rtl8192e: Rename function ActivateBAEntry
> > > > Staging: rtl8192e: Rename function DeActivateBAEntry
> > > > Staging: rtl8192e: Rename function TxTsDeleteBA
> > > > Staging: rtl8192e: Rename function RxTsDeleteBA
> > > > Staging: rtl8192e: Rename function ResetBaEntry
> > > >
> > > > drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> > > > drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 ++--
> > > > drivers/staging/rtl8192e/rtllib.h | 2 +-
> > > > 3 files changed, 26 insertions(+), 26 deletions(-)
> > > >
> > > Hi Tree,
> > >
> > > those patches have been accepted and cannot be applied again.
> > >
> >
> > Hi Philipp,
> >
> > Right, patch #5 was not accepted though. Grep asked to fix it up.
> > I thought that because it was part of that series I was supposed to
> > resend as new version.
>
> But now you understand what to do, right? Pull the latest code and do
> all your work on top of that. Don't resend the stuff which was applied.
>
> regards,
> dan carpenter
>
Understood. Thanks.
regards,
Tree
^ permalink raw reply [flat|nested] 9+ messages in thread