From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D211AD29; Mon, 14 Aug 2023 13:02:11 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-68843478de1so152921b3a.2; Mon, 14 Aug 2023 06:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692018130; x=1692622930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HKCht00peaRonZGA470AHkVGtx/YrtjPfOWO9GGrZzg=; b=Fi96PZ+q51r/KWaS0v82cIaUFj22W88rqrhcM3ZieVQlx2ln7ILx36SFagURvZk7bX OKeHqTTGgzh/wKBBPtvVUKRu4/pQ+DX7JFl6ngi1jO2arrGpANWcrc9t542R7ZxhE+Jh DapNfKOD0BV0gzOC70h5HwOpybapk8ywL+IkQQPmr7OcIszeqgZxn0UYesWtI+B17Kca gZRi+gAz77b6QQf7c0F2MsIr02AJ1GousrUqfIwKoPfn98m+P2mrgQCiyijgvlqOBn6F bKxk91GqVNapodqJVujfRDo6aH1Kzu/Ky/RcjUXrQaX517CKD6Sa5h76ehStDBaKA+9U 5qaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692018130; x=1692622930; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HKCht00peaRonZGA470AHkVGtx/YrtjPfOWO9GGrZzg=; b=LivYobeq8ONVD9IF7wWTUjUrUjLtqlc3yCdM6MXrSUzD2U2xVBzYGMS2BSgqolW1/y J8Ig0KDxe5t02W4GZGYdtL1BgKLhg3CTGiBwTCY63Jo7K9UJEWu0U7vfjSuLvbNzjqQJ jKzLhLZ+gCwU5jVFY4i+92y498fPqIzLe41oThOsV2LsROQh5+z/whUjHa8/e/ZkrqUY GYf6CY0FpgU233zYz/AoKhH6L1WsIVMewGT702+9ZbIXzjRyttmMPo/NTofIWSWyGpN7 LGn6OT+Zx5su5XIHvurBqcH4B4YJ75eEjGUETVKXudkon0vnjbMs305I5ThUvbmAZ6uv GoNQ== X-Gm-Message-State: AOJu0YyXqInOsFK7Z8RgVbIGBz6GViE4TAvy895xUkeZpch190iQwH4Q UAyp5bzQ0IUXLkqugnO/OCc= X-Google-Smtp-Source: AGHT+IFq133aawXmsL6sMEtTQbnpBUm3VWpWwop0jw8WiolamxjZOleHyHYPu/YQsquQWN0rn0zbkQ== X-Received: by 2002:a05:6a20:7f8e:b0:135:4527:efcc with SMTP id d14-20020a056a207f8e00b001354527efccmr11185059pzj.46.1692018130088; Mon, 14 Aug 2023 06:02:10 -0700 (PDT) Received: from ubuntu.myguest.virtualbox.org ([171.49.234.213]) by smtp.gmail.com with ESMTPSA id x42-20020a056a000bea00b00684b64da08bsm7889819pfu.132.2023.08.14.06.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 06:02:09 -0700 (PDT) Date: Mon, 14 Aug 2023 18:32:01 +0530 From: Pavan Bobba To: Julia Lawall , Forest Bond , Michael Straube , Philipp Hortmann , outreachy@lists.linux.dev Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: vt6655: replace camel case by snake case Message-ID: References: <2023081150-hamster-sulfide-4231@gregkh> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Aug 12, 2023 at 08:41:51PM +0200, Julia Lawall wrote: > > > On Sat, 12 Aug 2023, Pavan Bobba wrote: > > > On Fri, Aug 11, 2023 at 11:27:10PM +0200, Greg KH wrote: > > > On Wed, Aug 09, 2023 at 06:17:22PM +0530, Pavan Bobba wrote: > > > > Replace array name of camel case by snake case. Issue found > > > > by checkpatch > > > > > > > > Signed-off-by: Pavan Bobba > > > > --- > > > > v1 -> v2: 1. array name renamed from byVT3253B0_RFMD to by_vt3253b0_rfmd > > > > 2. typo in the subject line "small case" corrected with the > > > > proper word "snake case" > > > > > > > > Signed-off-by: Pavan Bobba > > > > --- > > > > drivers/staging/vt6655/baseband.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c > > > > index 0e135af8316b..cc8793256661 100644 > > > > --- a/drivers/staging/vt6655/baseband.c > > > > +++ b/drivers/staging/vt6655/baseband.c > > > > @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = > > > > }; > > > > > > > > #define CB_VT3253B0_INIT_FOR_RFMD 256 > > > > -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = { > > > > +static const unsigned char by_vt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = { > > > > > > Again, the "by" needs to just be dropped. > > > > > > thanks, > > > > > > greg k-h > > > > hi greg...did'nt get your comment. can you please provide more elaborate > > info? > > Drop the letter "by_" at the beginning of the function name. It is there > ot indicate the type, which isn't done in the kernel. > > julia this is'nt a function name but an array name. is in't it fine?