linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
@ 2023-08-12 20:16 Tree Davies
  2023-08-12 20:16 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba() Tree Davies
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

This patch series fixes checkpatch warning Avoid CamelCase, for all references
of struct rx_ts_record, and renames them to rx_ts for consistency and 
readability. Each patch renames references for a single function.

Thank you in advance to the reviewers
~ Tree 

Tree Davies (16):
  Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_ADDBAReq()
  Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_ts_init_del_ba()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_rx_ba_inact_timeout()
  Staging: rtl8192e: Rename variable pRxTs in function
    RxPktPendingTimeout()
  Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
  Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
  Staging: rtl8192e: Rename variable tmp in function GetTs()
  Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
  Staging: rtl8192e: Rename variable pTS in function prototype
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_indicate_packets()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pRxTS in function
    rtllib_rx_check_duplicate()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_InfraAdhoc()

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 36 ++++-----
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 72 ++++++++---------
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 drivers/staging/rtl8192e/rtllib_rx.c      | 94 +++++++++++------------
 4 files changed, 102 insertions(+), 102 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 01/16] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 20:16 ` [PATCH 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pBa in function rx_ts_delete_ba() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 0e3372868f97..1eff30533f47 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -41,9 +41,9 @@ static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record *pTxTs
 	return bSendDELBA;
 }
 
-static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *pRxTs)
+static u8 rx_ts_delete_ba(struct rtllib_device *ieee, struct rx_ts_record *rx_ts)
 {
-	struct ba_record *pBa = &pRxTs->rx_admitted_ba_record;
+	struct ba_record *pBa = &rx_ts->rx_admitted_ba_record;
 	u8			bSendDELBA = false;
 
 	if (pBa->b_valid) {
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
  2023-08-12 20:16 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba() Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 20:16 ` [PATCH 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pTS in function rtllib_rx_ADDBAReq() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 1eff30533f47..2748ab59545c 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -220,7 +220,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 	union ba_param_set *pBaParamSet = NULL;
 	u16 *pBaTimeoutVal = NULL;
 	union sequence_control *pBaStartSeqCtrl = NULL;
-	struct rx_ts_record *pTS = NULL;
+	struct rx_ts_record *rx_ts = NULL;
 
 	if (skb->len < sizeof(struct rtllib_hdr_3addr) + 9) {
 		netdev_warn(ieee->dev, "Invalid skb len in BAREQ(%d / %d)\n",
@@ -253,13 +253,13 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 			    ieee->ht_info->bCurrentHTSupport);
 		goto OnADDBAReq_Fail;
 	}
-	if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst,
+	if (!GetTs(ieee, (struct ts_common_info **)&rx_ts, dst,
 		   (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
 		rc = ADDBA_STATUS_REFUSED;
 		netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
 		goto OnADDBAReq_Fail;
 	}
-	pBA = &pTS->rx_admitted_ba_record;
+	pBA = &rx_ts->rx_admitted_ba_record;
 
 	if (pBaParamSet->field.ba_policy == BA_POLICY_DELAYED) {
 		rc = ADDBA_STATUS_INVALID_PARAM;
@@ -268,7 +268,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
 		goto OnADDBAReq_Fail;
 	}
 
-	rtllib_FlushRxTsPendingPkts(ieee, pTS);
+	rtllib_FlushRxTsPendingPkts(ieee, rx_ts);
 
 	deactivate_ba_entry(ieee, pBA);
 	pBA->dialog_token = *pDialogToken;
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
  2023-08-12 20:16 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba() Tree Davies
  2023-08-12 20:16 ` [PATCH 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 20:16 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function rtllib_rx_DELBA() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 2748ab59545c..39a5da44b8eb 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -430,9 +430,9 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 	pDelBaParamSet = (union delba_param_set *)&delba->payload[2];
 
 	if (pDelBaParamSet->field.initiator == 1) {
-		struct rx_ts_record *pRxTs;
+		struct rx_ts_record *rx_ts;
 
-		if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst,
+		if (!GetTs(ieee, (struct ts_common_info **)&rx_ts, dst,
 			   (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
 			netdev_warn(ieee->dev,
 				    "%s(): can't get TS for RXTS. dst:%pM TID:%d\n",
@@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
 			return -1;
 		}
 
-		rx_ts_delete_ba(ieee, pRxTs);
+		rx_ts_delete_ba(ieee, rx_ts);
 	} else {
 		struct tx_ts_record *pTxTs;
 
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (2 preceding siblings ...)
  2023-08-12 20:16 ` [PATCH 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 20:16 ` [PATCH 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function rtllib_ts_init_del_ba() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index 39a5da44b8eb..da2e53dea8e0 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -499,11 +499,11 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee,
 					(&pTxTs->TxPendingBARecord),
 					 TxRxSelect, DELBA_REASON_END_BA);
 	} else if (TxRxSelect == RX_DIR) {
-		struct rx_ts_record *pRxTs =
+		struct rx_ts_record *rx_ts =
 				 (struct rx_ts_record *)pTsCommonInfo;
-		if (rx_ts_delete_ba(ieee, pRxTs))
+		if (rx_ts_delete_ba(ieee, rx_ts))
 			rtllib_send_DELBA(ieee, pTsCommonInfo->Addr,
-					  &pRxTs->rx_admitted_ba_record,
+					  &rx_ts->rx_admitted_ba_record,
 					  TxRxSelect, DELBA_REASON_END_BA);
 	}
 }
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (3 preceding siblings ...)
  2023-08-12 20:16 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 20:16 ` [PATCH 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
  2023-08-12 21:13 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Nam Cao
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename varialbe pRxTs in function rtllib_rx_ba_inact_timeout() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
index da2e53dea8e0..d3f1454ba5b0 100644
--- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
@@ -532,13 +532,13 @@ void rtllib_tx_ba_inact_timeout(struct timer_list *t)
 
 void rtllib_rx_ba_inact_timeout(struct timer_list *t)
 {
-	struct rx_ts_record *pRxTs = from_timer(pRxTs, t,
+	struct rx_ts_record *rx_ts = from_timer(rx_ts, t,
 					      rx_admitted_ba_record.timer);
-	struct rtllib_device *ieee = container_of(pRxTs, struct rtllib_device,
-				     RxTsRecord[pRxTs->num]);
+	struct rtllib_device *ieee = container_of(rx_ts, struct rtllib_device,
+				     RxTsRecord[rx_ts->num]);
 
-	rx_ts_delete_ba(ieee, pRxTs);
-	rtllib_send_DELBA(ieee, pRxTs->ts_common_info.Addr,
-			  &pRxTs->rx_admitted_ba_record, RX_DIR,
+	rx_ts_delete_ba(ieee, rx_ts);
+	rtllib_send_DELBA(ieee, rx_ts->ts_common_info.Addr,
+			  &rx_ts->rx_admitted_ba_record, RX_DIR,
 			  DELBA_REASON_TIMEOUT);
 }
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout()
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (4 preceding siblings ...)
  2023-08-12 20:16 ` [PATCH 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
@ 2023-08-12 20:16 ` Tree Davies
  2023-08-12 21:13 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Nam Cao
  6 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-12 20:16 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan, error27
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pRxTs in function RxPktPendingTimeout() to rx_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 32 +++++++++++------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 24a8b9fc0168..1c78134fc625 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -10,10 +10,10 @@
 
 static void RxPktPendingTimeout(struct timer_list *t)
 {
-	struct rx_ts_record *pRxTs = from_timer(pRxTs, t,
+	struct rx_ts_record *rx_ts = from_timer(rx_ts, t,
 						     rx_pkt_pending_timer);
-	struct rtllib_device *ieee = container_of(pRxTs, struct rtllib_device,
-						  RxTsRecord[pRxTs->num]);
+	struct rtllib_device *ieee = container_of(rx_ts, struct rtllib_device,
+						  RxTsRecord[rx_ts->num]);
 
 	struct rx_reorder_entry *pReorderEntry = NULL;
 
@@ -22,24 +22,24 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	bool bPktInBuf = false;
 
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
-	if (pRxTs->rx_timeout_indicate_seq != 0xffff) {
-		while (!list_empty(&pRxTs->rx_pending_pkt_list)) {
+	if (rx_ts->rx_timeout_indicate_seq != 0xffff) {
+		while (!list_empty(&rx_ts->rx_pending_pkt_list)) {
 			pReorderEntry = (struct rx_reorder_entry *)
-					list_entry(pRxTs->rx_pending_pkt_list.prev,
+					list_entry(rx_ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, List);
 			if (index == 0)
-				pRxTs->rx_indicate_seq = pReorderEntry->SeqNum;
+				rx_ts->rx_indicate_seq = pReorderEntry->SeqNum;
 
 			if (SN_LESS(pReorderEntry->SeqNum,
-				    pRxTs->rx_indicate_seq) ||
+				    rx_ts->rx_indicate_seq) ||
 			    SN_EQUAL(pReorderEntry->SeqNum,
-				     pRxTs->rx_indicate_seq)) {
+				     rx_ts->rx_indicate_seq)) {
 				list_del_init(&pReorderEntry->List);
 
 				if (SN_EQUAL(pReorderEntry->SeqNum,
-				    pRxTs->rx_indicate_seq))
-					pRxTs->rx_indicate_seq =
-					      (pRxTs->rx_indicate_seq + 1) % 4096;
+				    rx_ts->rx_indicate_seq))
+					rx_ts->rx_indicate_seq =
+					      (rx_ts->rx_indicate_seq + 1) % 4096;
 
 				netdev_dbg(ieee->dev,
 					   "%s(): Indicate SeqNum: %d\n",
@@ -58,7 +58,7 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	}
 
 	if (index > 0) {
-		pRxTs->rx_timeout_indicate_seq = 0xffff;
+		rx_ts->rx_timeout_indicate_seq = 0xffff;
 
 		if (index > REORDER_WIN_SIZE) {
 			netdev_warn(ieee->dev,
@@ -72,9 +72,9 @@ static void RxPktPendingTimeout(struct timer_list *t)
 		bPktInBuf = false;
 	}
 
-	if (bPktInBuf && (pRxTs->rx_timeout_indicate_seq == 0xffff)) {
-		pRxTs->rx_timeout_indicate_seq = pRxTs->rx_indicate_seq;
-		mod_timer(&pRxTs->rx_pkt_pending_timer,  jiffies +
+	if (bPktInBuf && (rx_ts->rx_timeout_indicate_seq == 0xffff)) {
+		rx_ts->rx_timeout_indicate_seq = rx_ts->rx_indicate_seq;
+		mod_timer(&rx_ts->rx_pkt_pending_timer,  jiffies +
 			  msecs_to_jiffies(ieee->ht_info->rx_reorder_pending_time)
 			  );
 	}
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
                   ` (5 preceding siblings ...)
  2023-08-12 20:16 ` [PATCH 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
@ 2023-08-12 21:13 ` Nam Cao
  2023-08-12 23:11   ` Tree Davies
  6 siblings, 1 reply; 14+ messages in thread
From: Nam Cao @ 2023-08-12 21:13 UTC (permalink / raw)
  To: Tree Davies
  Cc: gregkh, philipp.g.hortmann, anjan, error27, linux-staging,
	linux-kernel

On Sat, Aug 12, 2023 at 01:16:46PM -0700, Tree Davies wrote:
> This patch series fixes checkpatch warning Avoid CamelCase, for all references
> of struct rx_ts_record, and renames them to rx_ts for consistency and 
> readability. Each patch renames references for a single function.
> 
> Thank you in advance to the reviewers
> ~ Tree 
> 
> Tree Davies (16):

Here it says there are 16 patches, but you have only sent 6 patches. Are some
of them missing?

Best regards,
Nam


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-12 21:13 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Nam Cao
@ 2023-08-12 23:11   ` Tree Davies
  2023-08-13  0:15     ` Tree Davies
  0 siblings, 1 reply; 14+ messages in thread
From: Tree Davies @ 2023-08-12 23:11 UTC (permalink / raw)
  To: Nam Cao
  Cc: gregkh, philipp.g.hortmann, anjan, error27, linux-staging,
	linux-kernel

On Sat, Aug 12, 2023 at 11:13:56PM +0200, Nam Cao wrote:
> On Sat, Aug 12, 2023 at 01:16:46PM -0700, Tree Davies wrote:
> > This patch series fixes checkpatch warning Avoid CamelCase, for all references
> > of struct rx_ts_record, and renames them to rx_ts for consistency and 
> > readability. Each patch renames references for a single function.
> > 
> > Thank you in advance to the reviewers
> > ~ Tree 
> > 
> > Tree Davies (16):
> 
> Here it says there are 16 patches, but you have only sent 6 patches. Are some
> of them missing?
> 
> Best regards,
> Nam
> 
Thanks Nam,

Yes they are missing. git send-email errored during submition. 
I will resend. 
Question: In this case do I need to send it as a v2?

Tree



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-12 23:11   ` Tree Davies
@ 2023-08-13  0:15     ` Tree Davies
  2023-08-13  6:30       ` Greg KH
  0 siblings, 1 reply; 14+ messages in thread
From: Tree Davies @ 2023-08-13  0:15 UTC (permalink / raw)
  To: Nam Cao
  Cc: gregkh, philipp.g.hortmann, anjan, error27, linux-staging,
	linux-kernel

On Sat, Aug 12, 2023 at 04:11:53PM -0700, Tree Davies wrote:
> On Sat, Aug 12, 2023 at 11:13:56PM +0200, Nam Cao wrote:
> > On Sat, Aug 12, 2023 at 01:16:46PM -0700, Tree Davies wrote:
> > > This patch series fixes checkpatch warning Avoid CamelCase, for all references
> > > of struct rx_ts_record, and renames them to rx_ts for consistency and 
> > > readability. Each patch renames references for a single function.
> > > 
> > > Thank you in advance to the reviewers
> > > ~ Tree 
> > > 
> > > Tree Davies (16):
> > 
> > Here it says there are 16 patches, but you have only sent 6 patches. Are some
> > of them missing?
> > 
> > Best regards,
> > Nam
> > 
> Thanks Nam,
> 
> Yes they are missing. git send-email errored during submition. 
> I will resend. 
> Question: In this case do I need to send it as a v2?
> 
> Tree
> 

OK, I know what happened. I was rate limited by my email provider.
I've requested a limit increase.

I suppose I could break up the patch-set into multiple series and label
them as series A, B, and C?

Tree

 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-13  0:15     ` Tree Davies
@ 2023-08-13  6:30       ` Greg KH
  2023-08-14 17:27         ` Tree Davies
  0 siblings, 1 reply; 14+ messages in thread
From: Greg KH @ 2023-08-13  6:30 UTC (permalink / raw)
  To: Tree Davies
  Cc: Nam Cao, philipp.g.hortmann, anjan, error27, linux-staging,
	linux-kernel

On Sat, Aug 12, 2023 at 05:15:15PM -0700, Tree Davies wrote:
> On Sat, Aug 12, 2023 at 04:11:53PM -0700, Tree Davies wrote:
> > On Sat, Aug 12, 2023 at 11:13:56PM +0200, Nam Cao wrote:
> > > On Sat, Aug 12, 2023 at 01:16:46PM -0700, Tree Davies wrote:
> > > > This patch series fixes checkpatch warning Avoid CamelCase, for all references
> > > > of struct rx_ts_record, and renames them to rx_ts for consistency and 
> > > > readability. Each patch renames references for a single function.
> > > > 
> > > > Thank you in advance to the reviewers
> > > > ~ Tree 
> > > > 
> > > > Tree Davies (16):
> > > 
> > > Here it says there are 16 patches, but you have only sent 6 patches. Are some
> > > of them missing?
> > > 
> > > Best regards,
> > > Nam
> > > 
> > Thanks Nam,
> > 
> > Yes they are missing. git send-email errored during submition. 
> > I will resend. 
> > Question: In this case do I need to send it as a v2?
> > 
> > Tree
> > 
> 
> OK, I know what happened. I was rate limited by my email provider.
> I've requested a limit increase.

Your email provider does not allow you to send more than 7 emails at
once?  You might want to switch companies if that's the case.

> I suppose I could break up the patch-set into multiple series and label
> them as series A, B, and C?

No, series are not labeled that way, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-13  6:30       ` Greg KH
@ 2023-08-14 17:27         ` Tree Davies
  0 siblings, 0 replies; 14+ messages in thread
From: Tree Davies @ 2023-08-14 17:27 UTC (permalink / raw)
  To: Greg KH
  Cc: Nam Cao, philipp.g.hortmann, anjan, error27, linux-staging,
	linux-kernel

On Sun, Aug 13, 2023 at 08:30:02AM +0200, Greg KH wrote:
> On Sat, Aug 12, 2023 at 05:15:15PM -0700, Tree Davies wrote:
> > On Sat, Aug 12, 2023 at 04:11:53PM -0700, Tree Davies wrote:
> > > On Sat, Aug 12, 2023 at 11:13:56PM +0200, Nam Cao wrote:
> > > > On Sat, Aug 12, 2023 at 01:16:46PM -0700, Tree Davies wrote:
> > > > > This patch series fixes checkpatch warning Avoid CamelCase, for all references
> > > > > of struct rx_ts_record, and renames them to rx_ts for consistency and 
> > > > > readability. Each patch renames references for a single function.
> > > > > 
> > > > > Thank you in advance to the reviewers
> > > > > ~ Tree 
> > > > > 
> > > > > Tree Davies (16):
> > > > 
> > > > Here it says there are 16 patches, but you have only sent 6 patches. Are some
> > > > of them missing?
> > > > 
> > > > Best regards,
> > > > Nam
> > > > 
> > > Thanks Nam,
> > > 
> > > Yes they are missing. git send-email errored during submition. 
> > > I will resend. 
> > > Question: In this case do I need to send it as a v2?
> > > 
> > > Tree
> > > 
> > 
> > OK, I know what happened. I was rate limited by my email provider.
> > I've requested a limit increase.
> 
> Your email provider does not allow you to send more than 7 emails at
> once?  You might want to switch companies if that's the case.

From what I understand it is 7 email-recipients x 16 patches in the set
violates their 50 email per 5 minute policy.

> 
> > I suppose I could break up the patch-set into multiple series and label
> > them as series A, B, and C?
> 
> No, series are not labeled that way, sorry.
> 
> greg k-h

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
@ 2023-08-20  0:47 Tree Davies
  2023-08-20  4:40 ` Philipp Hortmann
  0 siblings, 1 reply; 14+ messages in thread
From: Tree Davies @ 2023-08-20  0:47 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

The goal of this series is to fix checkpatch warning Avoid CamelCase,
for all references of struct rx_ts_record. In most cases renames the
references to, ts, to make the naming consistent.

The first 8 patches have been sent before, and versioned appropriately.

Thank you in advance to the reviewers,
~ Tree

Tree Davies (16):
  Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_ADDBAReq()
  Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_ts_init_del_ba()
  Staging: rtl8192e: Rename variable pRxTs in function
    rtllib_rx_ba_inact_timeout()
  Staging: rtl8192e: Rename variable pRxTs in function
    RxPktPendingTimeout()
  Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
  Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
  Staging: rtl8192e: Rename variable tmp in function GetTs()
  Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
  Staging: rtl8192e: Rename variable pTS in function prototype
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_FlushRxTsPendingPkts()
  Staging: rtl8192e: Rename variable pTS in function
    RxReorderIndicatePacket()
  Staging: rtl8192e: Rename variable pRxTS in function
    rtllib_rx_check_duplicate()
  Staging: rtl8192e: Rename variable pTS in function
    rtllib_rx_InfraAdhoc()

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 36 ++++-----
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 73 +++++++++---------
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 drivers/staging/rtl8192e/rtllib_rx.c      | 94 +++++++++++------------
 4 files changed, 102 insertions(+), 103 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references
  2023-08-20  0:47 Tree Davies
@ 2023-08-20  4:40 ` Philipp Hortmann
  0 siblings, 0 replies; 14+ messages in thread
From: Philipp Hortmann @ 2023-08-20  4:40 UTC (permalink / raw)
  To: Tree Davies, gregkh, anjan; +Cc: linux-staging, linux-kernel

On 8/20/23 02:47, Tree Davies wrote:
> The goal of this series is to fix checkpatch warning Avoid CamelCase,
> for all references of struct rx_ts_record. In most cases renames the
> references to, ts, to make the naming consistent.
> 
> The first 8 patches have been sent before, and versioned appropriately.
> 
> Thank you in advance to the reviewers,
> ~ Tree
> 
> Tree Davies (16):
>    Staging: rtl8192e: Rename variable pRxTs in function rx_ts_delete_ba()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_rx_ADDBAReq()
>    Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      rtllib_ts_init_del_ba()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      rtllib_rx_ba_inact_timeout()
>    Staging: rtl8192e: Rename variable pRxTs in function
>      RxPktPendingTimeout()
>    Staging: rtl8192e: Rename variable pTS in function ResetRxTsEntry()
>    Staging: rtl8192e: Rename variable pRxTS in function TSInitialize()
>    Staging: rtl8192e: Rename variable tmp in function GetTs()
>    Staging: rtl8192e: Rename variable pRxTS in function RemoveTsEntry()
>    Staging: rtl8192e: Rename variable pTS in function prototype
>      rtllib_FlushRxTsPendingPkts()
>    Staging: rtl8192e: Rename variable pTS in function AddReorderEntry()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_FlushRxTsPendingPkts()
>    Staging: rtl8192e: Rename variable pTS in function
>      RxReorderIndicatePacket()
>    Staging: rtl8192e: Rename variable pRxTS in function
>      rtllib_rx_check_duplicate()
>    Staging: rtl8192e: Rename variable pTS in function
>      rtllib_rx_InfraAdhoc()
> 
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 36 ++++-----
>   drivers/staging/rtl8192e/rtl819x_TSProc.c | 73 +++++++++---------
>   drivers/staging/rtl8192e/rtllib.h         |  2 +-
>   drivers/staging/rtl8192e/rtllib_rx.c      | 94 +++++++++++------------
>   4 files changed, 102 insertions(+), 103 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>




^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2023-08-20  4:41 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-12 20:16 [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Tree Davies
2023-08-12 20:16 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pBa in function rx_ts_delete_ba() Tree Davies
2023-08-12 20:16 ` [PATCH 02/16] Staging: rtl8192e: Rename variable pTS in function rtllib_rx_ADDBAReq() Tree Davies
2023-08-12 20:16 ` [PATCH 03/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_DELBA() Tree Davies
2023-08-12 20:16 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_ts_init_del_ba() Tree Davies
2023-08-12 20:16 ` [PATCH 05/16] Staging: rtl8192e: Rename variable pRxTs in function rtllib_rx_ba_inact_timeout() Tree Davies
2023-08-12 20:16 ` [PATCH 06/16] Staging: rtl8192e: Rename variable pRxTs in function RxPktPendingTimeout() Tree Davies
2023-08-12 21:13 ` [PATCH 00/16] Staging: rtl8192e: Rename struct rx_ts_record references Nam Cao
2023-08-12 23:11   ` Tree Davies
2023-08-13  0:15     ` Tree Davies
2023-08-13  6:30       ` Greg KH
2023-08-14 17:27         ` Tree Davies
  -- strict thread matches above, loose matches on Subject: below --
2023-08-20  0:47 Tree Davies
2023-08-20  4:40 ` Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).