From: Nam Cao <namcaov@gmail.com>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fix sii164InitChip function name
Date: Tue, 15 Aug 2023 07:35:59 +0200 [thread overview]
Message-ID: <ZNsOv7F1B9AnlUVG@nam-dell> (raw)
In-Reply-To: <20230815043759.404423-1-alkuor@gmail.com>
On Tue, Aug 15, 2023 at 12:37:59AM -0400, Abdel Alkuor wrote:
> Adhere to Linux Kernel coding style. Found by checkpatch.
>
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
> drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index e0c7ff3352bf..8b81e8642f9e 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -14,7 +14,7 @@
> static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
> #ifdef DVI_CTRL_SII164
> {
> - .init = sii164InitChip,
> + .init = sii164_init_chip,
> .get_vendor_id = sii164_get_vendor_id,
> .get_device_id = sii164GetDeviceID,
> #ifdef SII164_FULL_FUNCTIONS
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 3da1796cd7aa..d162e1a16584 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -72,7 +72,7 @@ unsigned short sii164GetDeviceID(void)
> */
>
> /*
> - * sii164InitChip
> + * sii164_init_chip
> * This function initialize and detect the DVI controller chip.
> *
> * Input:
> @@ -118,7 +118,7 @@ unsigned short sii164GetDeviceID(void)
> * 0 - Success
> * -1 - Fail.
> */
> -long sii164InitChip(unsigned char edge_select,
> +long sii164_init_chip(unsigned char edge_select,
> unsigned char bus_select,
> unsigned char dual_edge_clk_select,
> unsigned char hsync_enable,
I think you introduce new checkpatch warnings here.
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
> index ca330f6a43e2..13420bcc282c 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.h
> +++ b/drivers/staging/sm750fb/ddk750_sii164.h
> @@ -16,7 +16,7 @@ enum sii164_hot_plug_mode {
> };
>
> /* Silicon Image SiI164 chip prototype */
> -long sii164InitChip(unsigned char edgeSelect,
> +long sii164_init_chip(unsigned char edgeSelect,
> unsigned char busSelect,
> unsigned char dualEdgeClkSelect,
> unsigned char hsyncEnable,
Also here.
Best regards,
Nam
>
next prev parent reply other threads:[~2023-08-15 5:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 4:37 [PATCH] staging: sm750fb: fix sii164InitChip function name Abdel Alkuor
2023-08-15 5:35 ` Nam Cao [this message]
2023-08-15 18:44 ` Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNsOv7F1B9AnlUVG@nam-dell \
--to=namcaov@gmail.com \
--cc=alkuor@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox