From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: TheSven73@gmail.com, gregkh@linuxfoundation.org,
mripard@kernel.org, mchehab@kernel.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH -next 2/2] media: staging: media: sunxi: cedrus: Remove redundant of_match_ptr()
Date: Wed, 16 Aug 2023 12:09:47 +0200 [thread overview]
Message-ID: <ZNyga6GGlSiKpMqE@aptenodytes> (raw)
In-Reply-To: <20230811024945.2256437-3-ruanjinjie@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
Hi,
On Fri 11 Aug 23, 10:49, Ruan Jinjie wrote:
> The driver depends on CONFIG_OF, it is not necessary to use
> of_match_ptr() here.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Thanks for the patch!
Paul
> ---
> drivers/staging/media/sunxi/cedrus/cedrus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
> index 8e248d4a0aec..f52df6836045 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
> @@ -708,7 +708,7 @@ static struct platform_driver cedrus_driver = {
> .remove_new = cedrus_remove,
> .driver = {
> .name = CEDRUS_NAME,
> - .of_match_table = of_match_ptr(cedrus_dt_match),
> + .of_match_table = cedrus_dt_match,
> .pm = &cedrus_dev_pm_ops,
> },
> };
> --
> 2.34.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-08-16 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 2:49 [PATCH -next 0/2] staging: Remove redundant of_match_ptr() macro Ruan Jinjie
2023-08-11 2:49 ` [PATCH -next 1/2] staging: fieldbus: arcx-anybus: Remove redundant of_match_ptr() Ruan Jinjie
2023-08-11 2:49 ` [PATCH -next 2/2] media: staging: media: sunxi: cedrus: " Ruan Jinjie
2023-08-13 15:22 ` Jernej Škrabec
2023-08-16 10:09 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNyga6GGlSiKpMqE@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=TheSven73@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox