From: Pavan Bobba <opensource206@gmail.com>
To: Forest Bond <forest@alittletooquiet.net>,
Michael Straube <straube.linux@gmail.com>,
Philipp Hortmann <philipp.g.hortmann@gmail.com>,
outreachy@lists.linux.dev
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: vt6655: replace camel case by snake case
Date: Tue, 22 Aug 2023 20:58:09 +0530 [thread overview]
Message-ID: <ZOTUCRICU6lSYfdn@ubuntu.myguest.virtualbox.org> (raw)
Replace formal arguments of few functions and local variables of camel case by snake case.
Issue found by checkpatch
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
drivers/staging/vt6655/srom.c | 48 +++++++++++++++++------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index ee5ca4db74dc..c0dd4ad25472 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -59,36 +59,36 @@
unsigned char SROMbyReadEmbedded(void __iomem *iobase,
unsigned char byContntOffset)
{
- unsigned short wDelay, wNoACK;
- unsigned char byWait;
- unsigned char byData;
- unsigned char byOrg;
+ unsigned short wdelay, wnoack;
+ unsigned char bywait;
+ unsigned char bydata;
+ unsigned char byorg;
- byData = 0xFF;
- byOrg = ioread8(iobase + MAC_REG_I2MCFG);
+ bydata = 0xFF;
+ byorg = ioread8(iobase + MAC_REG_I2MCFG);
/* turn off hardware retry for getting NACK */
- iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
- for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
+ iowrite8(byorg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
+ for (wnoack = 0; wnoack < W_MAX_I2CRETRY; wnoack++) {
iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
iowrite8(byContntOffset, iobase + MAC_REG_I2MTGAD);
/* issue read command */
iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
/* wait DONE be set */
- for (wDelay = 0; wDelay < W_MAX_TIMEOUT; wDelay++) {
- byWait = ioread8(iobase + MAC_REG_I2MCSR);
- if (byWait & (I2MCSR_DONE | I2MCSR_NACK))
+ for (wdelay = 0; wdelay < W_MAX_TIMEOUT; wdelay++) {
+ bywait = ioread8(iobase + MAC_REG_I2MCSR);
+ if (bywait & (I2MCSR_DONE | I2MCSR_NACK))
break;
udelay(CB_DELAY_LOOP_WAIT);
}
- if ((wDelay < W_MAX_TIMEOUT) &&
- (!(byWait & I2MCSR_NACK))) {
+ if ((wdelay < W_MAX_TIMEOUT) &&
+ (!(bywait & I2MCSR_NACK))) {
break;
}
}
- byData = ioread8(iobase + MAC_REG_I2MDIPT);
- iowrite8(byOrg, iobase + MAC_REG_I2MCFG);
- return byData;
+ bydata = ioread8(iobase + MAC_REG_I2MDIPT);
+ iowrite8(byorg, iobase + MAC_REG_I2MCFG);
+ return bydata;
}
/*
@@ -98,20 +98,20 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
* In:
* iobase - I/O base address
* Out:
- * pbyEepromRegs - EEPROM content Buffer
+ * pbyeepromregs - EEPROM content Buffer
*
* Return Value: none
*
*/
-void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
+void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyeepromregs)
{
int ii;
/* ii = Rom Address */
for (ii = 0; ii < EEP_MAX_CONTEXT_SIZE; ii++) {
- *pbyEepromRegs = SROMbyReadEmbedded(iobase,
+ *pbyeepromregs = SROMbyReadEmbedded(iobase,
(unsigned char)ii);
- pbyEepromRegs++;
+ pbyeepromregs++;
}
}
@@ -122,19 +122,19 @@ void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
* In:
* iobase - I/O base address
* Out:
- * pbyEtherAddress - Ethernet Address buffer
+ * pbyetheraddress - Ethernet Address buffer
*
* Return Value: none
*
*/
void SROMvReadEtherAddress(void __iomem *iobase,
- unsigned char *pbyEtherAddress)
+ unsigned char *pbyetheraddress)
{
unsigned char ii;
/* ii = Rom Address */
for (ii = 0; ii < ETH_ALEN; ii++) {
- *pbyEtherAddress = SROMbyReadEmbedded(iobase, ii);
- pbyEtherAddress++;
+ *pbyetheraddress = SROMbyReadEmbedded(iobase, ii);
+ pbyetheraddress++;
}
}
--
2.34.1
next reply other threads:[~2023-08-22 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:28 Pavan Bobba [this message]
2023-08-22 15:32 ` [PATCH] staging: vt6655: replace camel case by snake case Julia Lawall
2023-08-22 17:31 ` Philipp Hortmann
2023-08-23 13:08 ` Pavan Bobba
-- strict thread matches above, loose matches on Subject: below --
2023-08-04 12:22 Pavan Bobba
2023-08-04 13:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOTUCRICU6lSYfdn@ubuntu.myguest.virtualbox.org \
--to=opensource206@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox