[PATCH] staging: vt6655: replace camel case by snake case

[PATCH] staging: vt6655: replace camel case by snake case

[Pavan Bobba]

Replace formal arguments of few functions and local variables of camel case by snake case.
Issue found by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
 drivers/staging/vt6655/srom.c | 48 +++++++++++++++++------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index ee5ca4db74dc..c0dd4ad25472 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -59,36 +59,36 @@
 unsigned char SROMbyReadEmbedded(void __iomem *iobase,
 				 unsigned char byContntOffset)
 {
-	unsigned short wDelay, wNoACK;
-	unsigned char byWait;
-	unsigned char byData;
-	unsigned char byOrg;
+	unsigned short wdelay, wnoack;
+	unsigned char bywait;
+	unsigned char bydata;
+	unsigned char byorg;
 
-	byData = 0xFF;
-	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
+	bydata = 0xFF;
+	byorg = ioread8(iobase + MAC_REG_I2MCFG);
 	/* turn off hardware retry for getting NACK */
-	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
-	for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
+	iowrite8(byorg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
+	for (wnoack = 0; wnoack < W_MAX_I2CRETRY; wnoack++) {
 		iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
 		iowrite8(byContntOffset, iobase + MAC_REG_I2MTGAD);
 
 		/* issue read command */
 		iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
 		/* wait DONE be set */
-		for (wDelay = 0; wDelay < W_MAX_TIMEOUT; wDelay++) {
-			byWait = ioread8(iobase + MAC_REG_I2MCSR);
-			if (byWait & (I2MCSR_DONE | I2MCSR_NACK))
+		for (wdelay = 0; wdelay < W_MAX_TIMEOUT; wdelay++) {
+			bywait = ioread8(iobase + MAC_REG_I2MCSR);
+			if (bywait & (I2MCSR_DONE | I2MCSR_NACK))
 				break;
 			udelay(CB_DELAY_LOOP_WAIT);
 		}
-		if ((wDelay < W_MAX_TIMEOUT) &&
-		    (!(byWait & I2MCSR_NACK))) {
+		if ((wdelay < W_MAX_TIMEOUT) &&
+		    (!(bywait & I2MCSR_NACK))) {
 			break;
 		}
 	}
-	byData = ioread8(iobase + MAC_REG_I2MDIPT);
-	iowrite8(byOrg, iobase + MAC_REG_I2MCFG);
-	return byData;
+	bydata = ioread8(iobase + MAC_REG_I2MDIPT);
+	iowrite8(byorg, iobase + MAC_REG_I2MCFG);
+	return bydata;
 }
 
 /*
@@ -98,20 +98,20 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
  *  In:
  *      iobase          - I/O base address
  *  Out:
- *      pbyEepromRegs   - EEPROM content Buffer
+ *      pbyeepromregs   - EEPROM content Buffer
  *
  * Return Value: none
  *
  */
-void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
+void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyeepromregs)
 {
 	int     ii;
 
 	/* ii = Rom Address */
 	for (ii = 0; ii < EEP_MAX_CONTEXT_SIZE; ii++) {
-		*pbyEepromRegs = SROMbyReadEmbedded(iobase,
+		*pbyeepromregs = SROMbyReadEmbedded(iobase,
 						    (unsigned char)ii);
-		pbyEepromRegs++;
+		pbyeepromregs++;
 	}
 }
 
@@ -122,19 +122,19 @@ void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
  *  In:
  *      iobase          - I/O base address
  *  Out:
- *      pbyEtherAddress - Ethernet Address buffer
+ *      pbyetheraddress - Ethernet Address buffer
  *
  * Return Value: none
  *
  */
 void SROMvReadEtherAddress(void __iomem *iobase,
-			   unsigned char *pbyEtherAddress)
+			   unsigned char *pbyetheraddress)
 {
 	unsigned char ii;
 
 	/* ii = Rom Address */
 	for (ii = 0; ii < ETH_ALEN; ii++) {
-		*pbyEtherAddress = SROMbyReadEmbedded(iobase, ii);
-		pbyEtherAddress++;
+		*pbyetheraddress = SROMbyReadEmbedded(iobase, ii);
+		pbyetheraddress++;
 	}
 }
-- 
2.34.1

Re: [PATCH] staging: vt6655: replace camel case by snake case

[Julia Lawall]

On Tue, 22 Aug 2023, Pavan Bobba wrote:

> Replace formal arguments of few functions and local variables of camel case by snake case.
> Issue found by checkpatch
>
> Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> ---
>  drivers/staging/vt6655/srom.c | 48 +++++++++++++++++------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index ee5ca4db74dc..c0dd4ad25472 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -59,36 +59,36 @@
>  unsigned char SROMbyReadEmbedded(void __iomem *iobase,
>  				 unsigned char byContntOffset)
>  {
> -	unsigned short wDelay, wNoACK;
> -	unsigned char byWait;
> -	unsigned char byData;
> -	unsigned char byOrg;
> +	unsigned short wdelay, wnoack;
> +	unsigned char bywait;
> +	unsigned char bydata;
> +	unsigned char byorg;

This raises the same problem as in your previous patch.  Here there is w
for word, by for byte, and later there is p for pointer.  All of these
encodings of type information should be dropped.

julia

>
> -	byData = 0xFF;
> -	byOrg = ioread8(iobase + MAC_REG_I2MCFG);
> +	bydata = 0xFF;
> +	byorg = ioread8(iobase + MAC_REG_I2MCFG);
>  	/* turn off hardware retry for getting NACK */
> -	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
> -	for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
> +	iowrite8(byorg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
> +	for (wnoack = 0; wnoack < W_MAX_I2CRETRY; wnoack++) {
>  		iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
>  		iowrite8(byContntOffset, iobase + MAC_REG_I2MTGAD);
>
>  		/* issue read command */
>  		iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
>  		/* wait DONE be set */
> -		for (wDelay = 0; wDelay < W_MAX_TIMEOUT; wDelay++) {
> -			byWait = ioread8(iobase + MAC_REG_I2MCSR);
> -			if (byWait & (I2MCSR_DONE | I2MCSR_NACK))
> +		for (wdelay = 0; wdelay < W_MAX_TIMEOUT; wdelay++) {
> +			bywait = ioread8(iobase + MAC_REG_I2MCSR);
> +			if (bywait & (I2MCSR_DONE | I2MCSR_NACK))
>  				break;
>  			udelay(CB_DELAY_LOOP_WAIT);
>  		}
> -		if ((wDelay < W_MAX_TIMEOUT) &&
> -		    (!(byWait & I2MCSR_NACK))) {
> +		if ((wdelay < W_MAX_TIMEOUT) &&
> +		    (!(bywait & I2MCSR_NACK))) {
>  			break;
>  		}
>  	}
> -	byData = ioread8(iobase + MAC_REG_I2MDIPT);
> -	iowrite8(byOrg, iobase + MAC_REG_I2MCFG);
> -	return byData;
> +	bydata = ioread8(iobase + MAC_REG_I2MDIPT);
> +	iowrite8(byorg, iobase + MAC_REG_I2MCFG);
> +	return bydata;
>  }
>
>  /*
> @@ -98,20 +98,20 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
>   *  In:
>   *      iobase          - I/O base address
>   *  Out:
> - *      pbyEepromRegs   - EEPROM content Buffer
> + *      pbyeepromregs   - EEPROM content Buffer
>   *
>   * Return Value: none
>   *
>   */
> -void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
> +void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyeepromregs)
>  {
>  	int     ii;
>
>  	/* ii = Rom Address */
>  	for (ii = 0; ii < EEP_MAX_CONTEXT_SIZE; ii++) {
> -		*pbyEepromRegs = SROMbyReadEmbedded(iobase,
> +		*pbyeepromregs = SROMbyReadEmbedded(iobase,
>  						    (unsigned char)ii);
> -		pbyEepromRegs++;
> +		pbyeepromregs++;
>  	}
>  }
>
> @@ -122,19 +122,19 @@ void SROMvReadAllContents(void __iomem *iobase, unsigned char *pbyEepromRegs)
>   *  In:
>   *      iobase          - I/O base address
>   *  Out:
> - *      pbyEtherAddress - Ethernet Address buffer
> + *      pbyetheraddress - Ethernet Address buffer
>   *
>   * Return Value: none
>   *
>   */
>  void SROMvReadEtherAddress(void __iomem *iobase,
> -			   unsigned char *pbyEtherAddress)
> +			   unsigned char *pbyetheraddress)
>  {
>  	unsigned char ii;
>
>  	/* ii = Rom Address */
>  	for (ii = 0; ii < ETH_ALEN; ii++) {
> -		*pbyEtherAddress = SROMbyReadEmbedded(iobase, ii);
> -		pbyEtherAddress++;
> +		*pbyetheraddress = SROMbyReadEmbedded(iobase, ii);
> +		pbyetheraddress++;
>  	}
>  }
> --
> 2.34.1
>
>
>

Re: [PATCH] staging: vt6655: replace camel case by snake case

[Philipp Hortmann]

On 8/22/23 17:28, Pavan Bobba wrote:
> Replace formal arguments of few functions and local variables of camel case by snake case.
> Issue found by checkpatch
> 
> Signed-off-by: Pavan Bobba<opensource206@gmail.com>

Hi,

please find a unique subject so that we see it is something new.

Thanks

Bye Philipp

Re: [PATCH] staging: vt6655: replace camel case by snake case

[Pavan Bobba]

On Tue, Aug 22, 2023 at 07:31:21PM +0200, Philipp Hortmann wrote:
> On 8/22/23 17:28, Pavan Bobba wrote:
> > Replace formal arguments of few functions and local variables of camel case by snake case.
> > Issue found by checkpatch
> > 
> > Signed-off-by: Pavan Bobba<opensource206@gmail.com>
> 
> Hi,
> 
> please find a unique subject so that we see it is something new.
> 
> Thanks
> 
> Bye Philipp
Thank you Philipp.i have updated my patch description in next patch

[PATCH] staging: vt6655: replace camel case by snake case

[Pavan Bobba]

Replace array name of camel case by snake case. Issue found
by checkpatch

Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 0e135af8316b..8b913c64845c 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] =
 };
 
 #define CB_VT3253B0_INIT_FOR_RFMD 256
-static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
+static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {
 	{0x00, 0x31},
 	{0x01, 0x00},
 	{0x02, 0x00},
@@ -2005,8 +2005,8 @@ bool bb_vt3253_init(struct vnt_private *priv)
 		} else {
 			for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
 				result &= bb_write_embedded(priv,
-					byVT3253B0_RFMD[ii][0],
-					byVT3253B0_RFMD[ii][1]);
+					byvt3253b0_rfmd[ii][0],
+					byvt3253b0_rfmd[ii][1]);
 
 			for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++)
 				result &= bb_write_embedded(priv,
-- 
2.34.1

Re: [PATCH] staging: vt6655: replace camel case by snake case

[Greg Kroah-Hartman]

On Fri, Aug 04, 2023 at 05:52:25PM +0530, Pavan Bobba wrote:
> Replace array name of camel case by snake case. Issue found
> by checkpatch
> 
> Signed-off-by: Pavan Bobba <opensource206@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 0e135af8316b..8b913c64845c 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -499,7 +499,7 @@ static const unsigned char by_vt3253_init_tab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] =
>  };
>  
>  #define CB_VT3253B0_INIT_FOR_RFMD 256
> -static const unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
> +static const unsigned char byvt3253b0_rfmd[CB_VT3253B0_INIT_FOR_RFMD][2] = {
>  	{0x00, 0x31},
>  	{0x01, 0x00},
>  	{0x02, 0x00},
> @@ -2005,8 +2005,8 @@ bool bb_vt3253_init(struct vnt_private *priv)
>  		} else {
>  			for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
>  				result &= bb_write_embedded(priv,
> -					byVT3253B0_RFMD[ii][0],
> -					byVT3253B0_RFMD[ii][1]);
> +					byvt3253b0_rfmd[ii][0],
> +					byvt3253b0_rfmd[ii][1]);
>  
>  			for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++)
>  				result &= bb_write_embedded(priv,
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot