From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: vme_user: Fix block comments where '*' on each line should be aligned
Date: Sun, 17 Sep 2023 13:51:23 +0200 [thread overview]
Message-ID: <ZQboO4KSoDuANDYe@HP-ENVY-Notebook> (raw)
In-Reply-To: <2023091339-mountain-asleep-9439@gregkh>
On Wed, Sep 13, 2023 at 10:33:24AM +0200, Greg KH wrote:
> On Sat, Sep 09, 2023 at 08:48:18PM +0200, Jonathan Bergh wrote:
> > Fixed checkpatch warnings where lines with '*' in block comments should
> > be aligned and were not as well as incorrect tab spacings at the start of
> > comment lines.
> >
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> > ---
> > drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++-------------
> > 1 file changed, 70 insertions(+), 70 deletions(-)
> >
> > diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> > index dbdf5dabaf90..9748b7897527 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.h
> > +++ b/drivers/staging/vme_user/vme_tsi148.h
> > @@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,
> > */
> > #define TSI148_LCSR_VMEFL 0x250
> >
> > - /*
> > - * VME exception.
> > - * offset 260
> > +/*
> > + * VME exception.
> > + * offset 0x260
>
> This change is not documented :(
>
> Also I have two 2/2 patches, yet they are both different :(
>
> Please fix this up and send a whole new series, properly versioned,
> as-is, I have no idea what to do here.
Great, thanks for your help with these.
next prev parent reply other threads:[~2023-09-17 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 18:48 [PATCH 2/2] staging: vme_user: Fix block comments where '*' on each line should be aligned Jonathan Bergh
2023-09-13 8:33 ` Greg KH
2023-09-17 11:51 ` Jonathan Bergh [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-05 19:46 Jonathan Bergh
2023-09-06 8:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQboO4KSoDuANDYe@HP-ENVY-Notebook \
--to=bergh.jonathan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox