[PATCH] staging: wlan-ng: remove unused function prototypes

[PATCH] staging: wlan-ng: remove unused function prototypes

[Calvince Otieno]

These functions are declared but not defined or used anywhere.
Their definitions were removed 15 years ago in the
commit cbec30c4c00c ("Staging: wlan-ng: Delete a large pile of
now-unused code.")

Signed-off-by: Calvince Otieno <calvncce@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
index 083a055ee986..8c3f1ac35913 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.h
+++ b/drivers/staging/wlan-ng/prism2mgmt.h
@@ -78,14 +78,6 @@ void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
 void prism2mgmt_bytestr2pstr(struct hfa384x_bytestr *bytestr,
 			     struct p80211pstrd *pstr);
 
-/* functions to convert Group Addresses */
-void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
-			    struct hfa384x *priv);
-int prism2mgmt_set_grpaddr(u32 did,
-			   u8 *prism2buf, struct p80211pstrd *pstr,
-			   struct hfa384x *priv);
-int prism2mgmt_get_grpaddr_index(u32 did);
-
 void prism2sta_processing_defer(struct work_struct *data);
 
 void prism2sta_commsqual_defer(struct work_struct *data);
-- 
2.34.1

Re: [PATCH] staging: wlan-ng: remove unused function prototypes

[Greg Kroah-Hartman]

On Sun, Oct 15, 2023 at 05:24:57PM +0300, Calvince Otieno wrote:
> These functions are declared but not defined or used anywhere.
> Their definitions were removed 15 years ago in the
> commit cbec30c4c00c ("Staging: wlan-ng: Delete a large pile of
> now-unused code.")
> 
> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 083a055ee986..8c3f1ac35913 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -78,14 +78,6 @@ void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
>  void prism2mgmt_bytestr2pstr(struct hfa384x_bytestr *bytestr,
>  			     struct p80211pstrd *pstr);
>  
> -/* functions to convert Group Addresses */
> -void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> -			    struct hfa384x *priv);
> -int prism2mgmt_set_grpaddr(u32 did,
> -			   u8 *prism2buf, struct p80211pstrd *pstr,
> -			   struct hfa384x *priv);
> -int prism2mgmt_get_grpaddr_index(u32 did);
> -
>  void prism2sta_processing_defer(struct work_struct *data);
>  
>  void prism2sta_commsqual_defer(struct work_struct *data);
> -- 
> 2.34.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] staging: wlan-ng: remove unused function prototypes

[Thomas Weißschuh]

Hi Calvince,

On 2023-10-15 17:24:57+0300, Calvince Otieno wrote:
> These functions are declared but not defined or used anywhere.
> Their definitions were removed 15 years ago in the
> commit cbec30c4c00c ("Staging: wlan-ng: Delete a large pile of
> now-unused code.")

The indicated commit seems to be incorrect for prism2mgmt_set_grpaddr().

Also for new versions of patches it is useful to explicitly Cc people
that commented on the previous versions. These people people may be
curious about the progress and it makes it easier for the patch to
receive a Reviewed-by from them.

Plus the points from the document linked by Greg's bot.

* Changelog compared to previous version.
* Increment of patch version counter in subject
(* Link to previous version of patch in lore.kernel.org)

> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers/staging/wlan-ng/prism2mgmt.h
> index 083a055ee986..8c3f1ac35913 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.h
> +++ b/drivers/staging/wlan-ng/prism2mgmt.h
> @@ -78,14 +78,6 @@ void prism2mgmt_pstr2bytestr(struct hfa384x_bytestr *bytestr,
>  void prism2mgmt_bytestr2pstr(struct hfa384x_bytestr *bytestr,
>  			     struct p80211pstrd *pstr);
>  
> -/* functions to convert Group Addresses */
> -void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> -			    struct hfa384x *priv);
> -int prism2mgmt_set_grpaddr(u32 did,
> -			   u8 *prism2buf, struct p80211pstrd *pstr,
> -			   struct hfa384x *priv);
> -int prism2mgmt_get_grpaddr_index(u32 did);
> -
>  void prism2sta_processing_defer(struct work_struct *data);
>  
>  void prism2sta_commsqual_defer(struct work_struct *data);
> -- 
> 2.34.1
>