From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B2DCC140; Thu, 19 Oct 2023 21:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S5tk2/F/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697751140; x=1729287140; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cw5t3VXt7tUZOXYsPRrDLRYcGpbLTXZ9huugpFgVVdo=; b=S5tk2/F/nh2Set71ZKZOWU4D2DwKz60DiX5gpgxGBCaruI8nVzPm5gV1 6KtB6p9mYkBLriFKTr/Y8D7TcUPU9txR/GH7T0M24Z3PHk0r77ZJ7c8Hb 14hAK53DAIHSCZhJqtvL/R5Ikt54NnHw9EJtkFHAdKVkywX/VxjeSeim3 JofTF1u59F1x8ypJk7OoUXCDJANcief6UENbz02cB4FUCdk4ebaZmfQuJ AoW99bVewz6eCWLu/U4dhaS31gaLI3cAKdL2axC2HdeR9GkFyZG8TyC0j L4A+fXJ6HEsa2XMirJyeLAniOQ/p6KkjJ6r6GZ/5EN4n31Ljmu+8YPDYo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="390258003" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="390258003" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 14:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="707002209" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="707002209" Received: from xuanyaoo-mobl.gar.corp.intel.com (HELO intel.com) ([10.214.165.172]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 14:32:13 -0700 Date: Thu, 19 Oct 2023 23:32:04 +0200 From: Andi Shyti To: Soumya Negi Cc: Andi Shyti , Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Julia Lawall , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 2/2] staging: vme_user: Use __func__ instead of function name Message-ID: References: <996c9f92e7fd288f67c02dfb0ba524ab7c5fe421.1697696951.git.soumya.negi97@gmail.com> <20231019191428.GA32717@Negi> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019191428.GA32717@Negi> Hi Soumya, > > On Thu, Oct 19, 2023 at 12:20:10AM -0700, Soumya Negi wrote: > > > Replace function names in message strings with __func__ to fix > > > all checkpatch warnings like: > > > > > > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', > > > this function's name, in a string > > > > > > Signed-off-by: Soumya Negi > > > > you forgot my ack here: > > > > Acked-by: Andi Shyti > > > > Andi > > Sorry I forgot the tag Andi. I'll add the tags in v3(Greg has suggested > more changes). There will be some new patches, so I'll leave the tags out in > those as you may want to review them first. no problem. I don't see reviews from Greg in this v2 series. If you are referring to the changelog, then you don't need to resend. Andi